prismlauncher / meta Goto Github PK

NeoForge changed its artifact id from forge to neoforge. updateNeoForge will need to pull both the old and new artifact ids. Hopefully no further changes will be needed

latest neoforge versions on 1.20.4 don't successfully download:

Instance update failed because: Game update failed: it was impossible to fetch the required libraries.
Reason:
One or more subtasks failed

from prism log:

 14214.885 D | Checksummed Download for: "net.neoforged:neoforge:20.4.178:universal" storage: "net/neoforged/neoforge/20.4.178/neoforge-20.4.178-universal.jar" url: "https://maven.neoforged.net/releases/net/neoforged/neoforge/20.4.178/neoforge-20.4.178-universal.jar"
 14214.942 D | Setting up api download
 14214.943 W | QWindowsWindow::setGeometry: Unable to set geometry 600x173+618+748 (frame: 618x220+609+710) on QWidgetWindow/"ProgressDialogWindow" on "C27JG5x". Resulting geometry: 600x255+618+748 (frame: 618x302+609+710) margins: 9, 38, 9, 9 minimum size: 480x138 MINMAXINFO(maxSize=POINT(x=0, y=0), maxpos=POINT(x=0, y=0), maxtrack=POINT(x=0, y=0), mintrack=POINT(x=618, y=220)))
 14215.497 W | Checksum mismatch, download is bad.
 14215.498 D | Setting up api download
 14215.805 W | Checksum mismatch, download is bad.
 14215.806 D | Setting up api download
 14216.100 W | Checksum mismatch, download is bad

not sure which versions exactly don't work, from discord "it seems everything post july is broken"
not sure if any other mc versions also don't work

In many older versions, -Djava.util.Arrays.useLegacyMergeSort=true is required otherwise the game sometimes crashes.

java.lang.IllegalArgumentException: Comparison method violates its general contract!
	at java.util.TimSort.mergeHi(TimSort.java:899)
	at java.util.TimSort.mergeAt(TimSort.java:516)
	at java.util.TimSort.mergeCollapse(TimSort.java:441)
	at java.util.TimSort.sort(TimSort.java:245)
	at java.util.Arrays.sort(Arrays.java:1512)
	at java.util.ArrayList.sort(ArrayList.java:1464)
	at java.util.Collections.sort(Collections.java:177)
        (for a1.1.2_01)
	at e.a(SourceFile:926)
	at iq.c(SourceFile:342)
	at iq.b(SourceFile:284)
	at net.minecraft.client.Minecraft.run(SourceFile:608)
	at java.lang.Thread.run(Thread.java:750)

https://github.com/zkitefly/unlisted-versions-of-minecraft/blob/master/other-versions.json

这是我在 Minecraft Wiki 上抓取的 Client jar / json 文件，希望能添加进 meta 中供更多玩家使用

与 mojang-minecraft-old-snapshots.json 格式相比仅缺少 wiki 属性，并且启动器并没有使用该属性，所以我就不增加了 :)

Operating System

Windows, Linux

Version of Prism Launcher

Prism Launcher 8.0

Version of Qt

Qt 5.15.10

Description of bug

I'm aware that 1.5.2 is a very old Minecraft version at this point, but I can't install Liteloader from the launcher, despite Liteloader being available for 1.5.2.
http://www.liteloader.com/download shows this:

While Prism Launcher shows this:

However, I am able to install Forge through the launcher just fine.

Steps to reproduce

1. Create a new instance
2. Select Minecraft version 1.6.1 or older
3. Click Install Loader
4. Select LiteLoader.
5. See "No versions are currently available for Minecraft 1.x.x"

Suspected cause

The earliest version I'm able to install Liteloader on in Prism is 1.6.2. Anything earlier than that (not including snapshots) simply doesn't show. I do see on the Liteloader website that 1.5.2 is the earliest version, and the next one up is 1.6.2. I don't know if there's a correlation, but that's just my observation.

This issue is unique

• I have searched the issue tracker and did not find an issue describing my bug.

Operating System

Windows

Version of Prism Launcher

6.3

Version of Qt

Qt 6.4.2

Description of bug

Today, on 01.05.2023, Quilt Loader versions got "re-published" in a weird manner. First of all, not all versions of the loader are present. Second, versions are displayed in reverse, e.g. an old 0.16.x branch is above the latest 0.19.x. And lastly, all of them are marked as released today.

Initially, I contacted Quilt about it, but was told, that Quilt doesn't even provide the publishing date, so it didn't seem like the issue on their end. I then checked the standalone Quilt installer and that one indeed does not have the same issue.

Steps to reproduce

Simply open the instance creation window and select Quilt as your modloader. Alternatively use an already existing instance and use the "Edit" function.

Suspected cause

No response

This issue is unique

• I have searched the issue tracker and did not find an issue describing my bug.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Operating System

Windows

Version of Prism Launcher

Prism Launcher 8.3

Version of Qt

Qt 6.6.3

Description of bug

Workaround: on 1.20.1, you should be able to use Forge instead, as far as i know they are identical

Prism isn't able to launch a 1.20.1 neoforge (47.1.105) instance: https://mclo.gs/FYknZJU
neoforge works fine for me on 1.20.4
discord #support thread: https://discord.com/channels/1031648380885147709/1235648556011094057

Steps to reproduce

• make a 1.20.1 neoforge instance
• launch it

Suspected cause

similar to PrismLauncher/PrismLauncher#2170 ?

This issue is unique

• I have searched the issue tracker and did not find an issue describing my bug.

The logic here is not correct: https://github.com/PrismLauncher/meta/blob/master/generateFabric.py#L72-L73

As seen here (at the time of writing): https://meta.fabricmc.net/v2/versions/loader loader 0.14.15 is not marked as stable, 0.14.14 should be the default version users install.

It seems my change made here: 6f74290 was lost during a refactor.