process-analytics / mxgraph-sketch Goto Github PK

That kind of export can be done by using mxImageExport and a custom mxSvgCanvas2D

Elements to be documented

• adapted from https://drawio-app.com/introducing-draw-ios-new-sketch-feature/
• same mxgraph style configuration names as in draw.io
• add a gif of our example
• architecture: add a class diagram to explain how we extend the mxSvgCanvas2D (image in svg or draw.io)
• explain differences with the draw.io implementation

The configuration was created almost 2 years ago. Gitpod no longer rely on theia, so review the configuration.
See also process-analytics/bpmn-visualization-js#2003

mxgraph-type-definitions is not maintained anymore and has been replaced by typed-mxgraph

• change repository settings. Done on 2022-06-01
• ensure the GH Actions are still working. See #87

With the initial implementation, the outline also use the sketch mode (even if some code is in place to avoid it)
We probably should disable it by default and add an option to enable it.
Notice that the draw.io implementation (at least the one of August 2020) also use sketch in mxgraph outline.

Generally, the outline style is simpler that the regular graph to improve performances: for instance, it doesn't display labels.

Build

The rollup configuration has been taken from https://github.com/process-analytics/bpmn-visualization-js and is too complicated here.
Some parts are not used

Code

• Remove comments
• Clarify TSDoc
• Review class and file names

Initially, we use release-drafter as we do in bpmn-visualization. But here we don't need to have a template
There is no need for guidance, we don't need to reference to milestone in the introduction as we are not using milestone to group issues in this repository, ....

• Remove release-drafter and workflow
• Add the GitHub release notes configuration and consider all existing labels

Pending questions

• Have a simpler example in index.html (no dynamicity, take the mxgraph graph from official example?) and more complex in other pages?
• Move examples to a dedicated folder
• The current example should mentionned that it is adapted from the graph layout official mxgraph example
• Make the dev server work
• Ensure example can work with js resources from CDN
• Have a live demo (with statically.io?)

Same as draw.io, which is a bridge to roughjs configuration properties.

• roughjs doc: https://github.com/rough-stuff/rough/wiki#options
• available styles:

  mxgraph-sketch/src/SketchySvgCanvas.ts

  Line 78 in 4856acc

  // Applies cell style