Comments (9)
Well, as said in my first post in the point class documentation
from p5.js.
Welcome! ๐ Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!
from p5.js.
Hi, I'd like to be assigned this issue (as a good first issue to get started). Are you happy if I implement the fix?
from p5.js.
Thanks @Paulo005 for catching it and @NicholasGillen for your interest.
Hi @nickmcintyre, what's your thought on the this before we assign the issue?
from p5.js.
Hi @Paulo005, I have tested the issue and indeed there is some confusion regarding the documentation, I tested 3 situations that require 1 parameter and 2 parameters: https://editor.p5js.org/AlexJia/sketches/t5uvK0VOS and seems like they all work as expected. I think we can just simply change the documentation from
"The version of point() with one parameter allows the point's location to be set with its x- and y-coordinates, as in point(10, 20)."
to :
"The version of point() with two parameters allows the point's location to be set with its x- and y-coordinates, as in point(10, 20)."
And include another line that specifically addresses the usage of one parameter in the point() class.
@Qianqianye If it's possible, I'd like to be assigned for this issue, thanks!
from p5.js.
Good catch @Paulo005!
It'd be helpful to replace "one parameter" with "two parameters" as you suggested: The version of point()
with two parameters allows the point's location to be set with its x- and y-coordinates, as in point(10, 20)
.
The one-parameter version could also be clarified a bit: The version of point()
with one parameter allows the point's location to be set with a p5.Vector object, as in point(myVector)
.
That description was placed last because vectors are an advanced topic and it's a less common use case. Reading it again, it seems like we should order the descriptions by the number of parameters 1-2-3. Thoughts?
from p5.js.
hi @yaojiejia Yes the class seems to work with one parameter, in my code that cleary didnt work but as I was working with a lot of librairies it surely comes from me. In a raw sketch that works well. I think there no bug, just a little misprint in the documentation !
TY for testing it !
from p5.js.
@Paulo005 I would like to work on this issue. Could you please tell me where we should make the changes?
from p5.js.
can i fix this issue
from p5.js.
Related Issues (20)
- getting wrong language in the console. HOT 9
- Hit detection on 2D Shapes HOT 1
- Docker implementation HOT 3
- Broken link to dev_notes.md in the documentation HOT 1
- p5.Vector reflect() unexpectedly modifies surface normal argument HOT 3
- [p5.js 2.0 RFC Proposal]: Pruning HOT 2
- orbitControl() customizability HOT 3
- clearDepth() example broken
- Add an easier way to disable right-click context menus on the canvas HOT 8
- [p5.js 2.0 RFC Proposal]: Promises HOT 4
- Clipping to multiline text only works with the final line
- a typo in createCanvas() reference๏ผ HOT 3
- Reference page of Quad (2D Primitives) HOT 6
- Broken link to contribution docs in the README.md HOT 1
- Slight mistake in description of scale() effect in reference HOT 3
- Broken links in README ('Learning' and 'Get Started' sections) HOT 1
- textWidth gives wrong value on setup function HOT 3
- Text-based canvas accessibility throws error on out-of-Y-bounds shapes HOT 6
- Inconsistent instance mode canvas sizing HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from p5.js.