Giter VIP home page Giter VIP logo

Comments (9)

Paulo005 avatar Paulo005 commented on July 18, 2024 1

Well, as said in my first post in the point class documentation

from p5.js.

welcome avatar welcome commented on July 18, 2024

Welcome! ๐Ÿ‘‹ Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

from p5.js.

NicholasGillen avatar NicholasGillen commented on July 18, 2024

Hi, I'd like to be assigned this issue (as a good first issue to get started). Are you happy if I implement the fix?

from p5.js.

Qianqianye avatar Qianqianye commented on July 18, 2024

Thanks @Paulo005 for catching it and @NicholasGillen for your interest.
Hi @nickmcintyre, what's your thought on the this before we assign the issue?

from p5.js.

yaojiejia avatar yaojiejia commented on July 18, 2024

Hi @Paulo005, I have tested the issue and indeed there is some confusion regarding the documentation, I tested 3 situations that require 1 parameter and 2 parameters: https://editor.p5js.org/AlexJia/sketches/t5uvK0VOS and seems like they all work as expected. I think we can just simply change the documentation from
"The version of point() with one parameter allows the point's location to be set with its x- and y-coordinates, as in point(10, 20)."
to :
"The version of point() with two parameters allows the point's location to be set with its x- and y-coordinates, as in point(10, 20)."
And include another line that specifically addresses the usage of one parameter in the point() class.
@Qianqianye If it's possible, I'd like to be assigned for this issue, thanks!

from p5.js.

nickmcintyre avatar nickmcintyre commented on July 18, 2024

Good catch @Paulo005!

It'd be helpful to replace "one parameter" with "two parameters" as you suggested: The version of point() with two parameters allows the point's location to be set with its x- and y-coordinates, as in point(10, 20).

The one-parameter version could also be clarified a bit: The version of point() with one parameter allows the point's location to be set with a p5.Vector object, as in point(myVector).

That description was placed last because vectors are an advanced topic and it's a less common use case. Reading it again, it seems like we should order the descriptions by the number of parameters 1-2-3. Thoughts?

from p5.js.

Paulo005 avatar Paulo005 commented on July 18, 2024

hi @yaojiejia Yes the class seems to work with one parameter, in my code that cleary didnt work but as I was working with a lot of librairies it surely comes from me. In a raw sketch that works well. I think there no bug, just a little misprint in the documentation !

TY for testing it !

from p5.js.

Chaitanya1672 avatar Chaitanya1672 commented on July 18, 2024

@Paulo005 I would like to work on this issue. Could you please tell me where we should make the changes?

from p5.js.

kmr-ankitt avatar kmr-ankitt commented on July 18, 2024

can i fix this issue

from p5.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.