Comments (9)
i think i prefer the empty default to the nginx/pause version. it seems like if we have a default of pause, then we'd need to introduce another parameter to toggle the broker/services on/off ... whereas if we defaulted the image to empty, we could use the image parameter (and whether it was set) as the toggle for the broker/services on/off.
from akri.
in the udev template, should we default have the instance and configuration services? It seems like no, since by default there is no broker
from akri.
good idea! what would the default broker pod be for the udev template (the udevVideo template uses our udev video broker as a default)?
from akri.
Do we need one? It can be specified as a parameter to helm chart or expected to be replaced from the template configuration, no?
Also re #69, there should be a way to not force one.
from akri.
good call on #69. definitely agree with that.
the pod is a parameter now, so it should definitely be configurable (https://github.com/deislabs/akri/blob/0f9253dbd3875d3e8e5d5c3f1d1ee42e4e15e29a/deployment/helm/values.yaml#L186).
for the udev (as distinct from udevVideo), we could make udev.brokerPod.image.repository
default to empty and could make it so that brokerPodSpec is only applied if udev.brokerPod.image.repository
is supplied?
if someone didn't specify udev.brokerPod.image.repository
, then no brokerPod would be added to their udev configuration.
from akri.
Agreed on empty default.
Even for udevvideo/onvifvideo, not sure how much are our brokers really defaults as opposed to samples, but perhaps that is a separate question. We might not want to have them as defaults as folks might take dependency and then we would have to worry about breaking changes.
from akri.
Other option would be to set nginx as default like we do in DebugEcho, but i like the option of no broker Pod. Then, people could use Akri to advertise udev resources and schedule their own pods to those resources.
from akri.
Right; also, if we wanted to use a placeholder, would consider using pause instead of nginx for smaller footprint.
from akri.
Makes sense; we should just document how to add them back.
from akri.
Related Issues (20)
- udev-video-broker gets OOM error in microk8s HOT 2
- Remove dependency on outdated cross images HOT 6
- Akri discovery handler unable to detect ip camera HOT 5
- Controller pod restarts when instance watcher restarts HOT 1
- Transport error when Agent calls gRPC discover() to some Discovery Handlers
- Use rust-based coverage tools rather than tarpaulin HOT 1
- LoRaWAN Support HOT 7
- OPC-UA Instance ID: ApplicationName is not the best choice ? HOT 1
- Pods with unready Containers exist on this node, we can't clean the slots yet HOT 5
- containerd.socket mounting inside container - security concern / best practice deviation? HOT 5
- agent-registration.sock and udev.sock socket files world readable HOT 2
- Multiple configuration doesnt work -- helm install fails on rbac.enabled=false HOT 1
- RUSTSEC-2024-0003: Resource exhaustion vulnerability in h2 may lead to Denial of Service (DoS) HOT 1
- Put Akri on Adoption List of Related Projects HOT 3
- Switch from Prometheus to Open Telemetry for metric HOT 2
- Need to restart Configuration validating webhook when certificates are rotated HOT 2
- Discovery Handlers should generate universal device ID HOT 2
- Use cert-manager to manage webhook certs HOT 1
- RUSTSEC-2024-0320: yaml-rust is unmaintained. HOT 1
- (Define and) use Akri-specific Secret types HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from akri.