Giter VIP home page Giter VIP logo

Comments (9)

bfjelds avatar bfjelds commented on August 22, 2024 2

i think i prefer the empty default to the nginx/pause version. it seems like if we have a default of pause, then we'd need to introduce another parameter to toggle the broker/services on/off ... whereas if we defaulted the image to empty, we could use the image parameter (and whether it was set) as the toggle for the broker/services on/off.

from akri.

kate-goldenring avatar kate-goldenring commented on August 22, 2024 1

in the udev template, should we default have the instance and configuration services? It seems like no, since by default there is no broker

from akri.

bfjelds avatar bfjelds commented on August 22, 2024

good idea! what would the default broker pod be for the udev template (the udevVideo template uses our udev video broker as a default)?

from akri.

jiria avatar jiria commented on August 22, 2024

Do we need one? It can be specified as a parameter to helm chart or expected to be replaced from the template configuration, no?

Also re #69, there should be a way to not force one.

from akri.

bfjelds avatar bfjelds commented on August 22, 2024

good call on #69. definitely agree with that.

the pod is a parameter now, so it should definitely be configurable (https://github.com/deislabs/akri/blob/0f9253dbd3875d3e8e5d5c3f1d1ee42e4e15e29a/deployment/helm/values.yaml#L186).

for the udev (as distinct from udevVideo), we could make udev.brokerPod.image.repository default to empty and could make it so that brokerPodSpec is only applied if udev.brokerPod.image.repository is supplied?

if someone didn't specify udev.brokerPod.image.repository, then no brokerPod would be added to their udev configuration.

from akri.

jiria avatar jiria commented on August 22, 2024

Agreed on empty default.

Even for udevvideo/onvifvideo, not sure how much are our brokers really defaults as opposed to samples, but perhaps that is a separate question. We might not want to have them as defaults as folks might take dependency and then we would have to worry about breaking changes.

from akri.

kate-goldenring avatar kate-goldenring commented on August 22, 2024

Other option would be to set nginx as default like we do in DebugEcho, but i like the option of no broker Pod. Then, people could use Akri to advertise udev resources and schedule their own pods to those resources.

from akri.

jiria avatar jiria commented on August 22, 2024

Right; also, if we wanted to use a placeholder, would consider using pause instead of nginx for smaller footprint.

from akri.

jiria avatar jiria commented on August 22, 2024

Makes sense; we should just document how to add them back.

from akri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.