Giter VIP home page Giter VIP logo

Comments (6)

ngdangtu-vn avatar ngdangtu-vn commented on July 17, 2024

Also, may I ask why we wrap a whole parse inside the FluentResource class constructor? Can we use private method if we don't want it to get exposed?

from fluent.js.

zbraniecki avatar zbraniecki commented on July 17, 2024

But FluentBundle doesn't seems to support it.

The idea behind the bundle is that it can be composed of files from many sources.
In other words, a message with id foo can be provided by either file menus.ftl or common.ftl. Your request for prefixes would not work with that.

It may be useful for different models than we planned.

may I ask why we wrap a whole parse inside the FluentResource class constructor?

Intentional as well. You're not supposed to handle AST in runtime.

from fluent.js.

ngdangtu-vn avatar ngdangtu-vn commented on July 17, 2024

Can we add prefix on FluentResource?

new FluentResource('msg-id = a message ID', { namespace: 'prefix' })

Intentional as well. You're not supposed to handle AST in runtime.

Ok, cool.

from fluent.js.

stasm avatar stasm commented on July 17, 2024

FluentResource was written a long time ago, when private methods didn't exist in JS. Today, moving the parsing logic to a private method would probably make sense.

from fluent.js.

ngdangtu-vn avatar ngdangtu-vn commented on July 17, 2024

FluentResource was written a long time ago, when private methods didn't exist in JS. Today, moving the parsing logic to a private method would probably make sense.

I think I can do that, if you don't mind.

from fluent.js.

stasm avatar stasm commented on July 17, 2024

CC @eemeli, who leads the development of Fluent.

from fluent.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.