Giter VIP home page Giter VIP logo

Comments (2)

kueda avatar kueda commented on July 17, 2024 1

Thank you, @eemeli! I've been tinkering with this today and came to the same conclusion you did about this package behaving as expected, so I'll close this. Thank you for adding that test. And good point about "a/n" and vowel-ish sounds in English. I may try your regex, though we'll see how it performs with all the other languages.

from fluent.js.

eemeli avatar eemeli commented on July 17, 2024

You're right, this was not well enough covered by tests. So I added one in fee2242 to verify that it works as expected in our code. This might indeed be a bug in another package.

On a separate note, the English rules for a/an are primarily dependent on the sound and secondarily on customs, rather than the letter starting the word, and just checking against aeiou will often not work. A while back in a somewhat different context, I ended up putting together this regexp, which is still wrong, but perhaps a little bit less wrong than your current check.

from fluent.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.