Comments (2)
Thank you, @eemeli! I've been tinkering with this today and came to the same conclusion you did about this package behaving as expected, so I'll close this. Thank you for adding that test. And good point about "a/n" and vowel-ish sounds in English. I may try your regex, though we'll see how it performs with all the other languages.
from fluent.js.
You're right, this was not well enough covered by tests. So I added one in fee2242 to verify that it works as expected in our code. This might indeed be a bug in another package.
On a separate note, the English rules for a/an are primarily dependent on the sound and secondarily on customs, rather than the letter starting the word, and just checking against aeiou
will often not work. A while back in a somewhat different context, I ended up putting together this regexp, which is still wrong, but perhaps a little bit less wrong than your current check.
from fluent.js.
Related Issues (20)
- [fluent-syntax] Calling `clone()` on a node should return a value with node's type, not `BaseNode`
- Ability to compile bundle into a smaller resource HOT 4
- Tests are ignoring junk annotations HOT 2
- Support range versions of NUMBER and DATETIME as default builtins HOT 4
- [fluent-react] Support ref forwarding in `withLocalization` HOT 1
- Disabling unicode isolation on per-placeable basis HOT 2
- Locale regex doesnt take into account UN.M49 HOT 1
- Trying to convert Fluent to ActionScript HOT 1
- Porting FluentJS to ActionScript
- @fluent/react marks @fluent/bundle as incompatible
- Intl.DateTimeFormat timeZone option HOT 1
- DOMLocalization setArgs method
- Convert FluentSyntax.jsm to an ES module
- Lines with unusual characters at start inside of multiline text do not get properly recognized. HOT 4
- Request Feature: Support prefix identifier for message HOT 6
- RFC: fluent babel plugin
- Synchronising `.ftl` files and finding fluent IDs
- [Question] How can a variable be referenced in terms params?
- Uncaught TypeError: Failed to resolve module specifier "cached-iterable" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluent.js.