projectfluent / play Goto Github PK

It seems it even cannot load gists anymore. When I try to do so, I get timeouts or similar JS errors similar to #6

• One old link here https://projectfluent.io/play/?gist=400ca1160898d72f5935796a9982b22b results in server/response timeouts.
• One manually crafted new gist results in a server response https://projectfluent.org/play/?gist=b7886c7332dac68d9b83ed534b5062e0, but the whole page is just empty and I get plenty of JS errors.

The messages pane and config pane both have Ace editors with <.. id="brace-editor">. This trips up anything trying to consume this HTML in a standards-compliant way. An example would be Firenvim, see this issue.

Moved from: projectfluent/fluent#53

Repro case:
http://projectfluent.io/play/?gist=400ca1160898d72f5935796a9982b22b

As of mid-March, GitHub no longer allows anonymous creation of gists via the web UI nor the API. This affects the Playground's ability to save the editor state to the cloud for sharing with other people.

There are two ways to solving this:

1. Enable authentication. We could use the react-github-login component or rollout something more advanced, like Auth0 which also integrates with react quite nicely.

2. Change the storage backend. There are a number of anonymous cloud store solutions for JSON. A quick Google search came up with https://jsonbin.io/ and https://www.jsonstore.io/. This approach is possibly easier to implement and also offers the same UX as we used to have: no auth required. However it comes with two major drawbacks:

   • We might run into the same problem later in the future if the storage solution we choose sunsets or introduces the auth requirement to combat spam.

   • We'd want to keep the ?gist param around to allow reading gists created in the past. And we'd need to add new code to handle the new storage solution. We'd end up with two code paths doing the same thing which is likely to end up being a maintenance headache.

My recommendation is to bite the bullet and go with react-github-login.

The reference parser landed in projectfluent/fluent#103.

STR:

1. Click on "Share via Gist"

Happens:
For the user: Nothing visible. (This is bad! There should be user feedback even in the case of an error.)

JS:

 ReferenceError: regeneratorRuntime is not defined[Learn More] actions.js:53:11

    o actions.js:53 t2Redux
    s15React
    An (index):1018 

Expected:
Error or so.

Or make it work, but that may be hard due to #3

This Mozilla repository has been identified as lacking a license. Consistent with Mozilla's Licensing Policy an open source license should be applied to the code in this repository.

Please add an appropriate LICENSE.md file to the root directory of the project. In general, Mozilla's licensing policies are as follows:

• Client-side products created by Mozilla employees or contributors should use the Mozilla Public License, Version 2.0 (MPL).

• Server-side products or utilities that support Mozilla products may use either the MPL or the Apache License 2.0 (Apache 2.0).

In special cases, another license might be appropriate. If the repository is a fork of another repository it must apply the license of the original. Similarly, another license might be appropriate to match that of a broader project (for example Rust crates that Firefox depends on are published under an Apache 2.0 / MIT dual license, as that is the dual license used by the Rust programming language and projects).

Please ensure that any license added to the LICENSE.md file matches other licensing information in the repository (for example, it should match any license indicated in a setup.py or package.json file).

Mozilla staff can access more information in our Software Licensing Runbook – search for “Licensing Runbook” in Confluence to find it.

If you have any questions you can contact Daniel Nazer who can be reached at dnazer on Mozilla email or Slack.

OPENLIC-2023-01