projectpokemon / ppre Goto Github PK

The current READMEs reflect the older merged in repositories. Create a new README that reflects the current version with proper material for getting started.

Script Goto and Jump are handled identically, when one is supposed to be a push to the stack while the other just branches without a return link. Similarly, End and Killscript are both just returning when one is used to pop from the stack back to the old function.

This needs further investigation into a decent implementation.

Update with current versions. Either link to GitHub repositories or move dependencies to pypi.
PyQt cannot be in requirements. Maybe this can be in a setup.py?

Allow for methods that accept reader as their argument to have a @provides_reader decorator to pass in a valid reader from a Data String, file, or IO object.

Allow for methods that accept writer as an argument to have a @provides_writer decorator to generate a writer if one is not passed. This should also throw an error if a writer is not returned from a save() function.

Some commands feature characters such as "?" or "-" which are not valid. All command names should be Pythonic in nature. Ideally all commands are named using underscore_notation_no_caps, but remember to keep the old ones in the alias definitions.

Provide Editable with an __init__ that automatically calls a define(self, *args, **kwargs) and calls freeze()` afterwards to simplify definitions.

It can also call load() if provided with a reader.

The old rawdb files take up a lot of the root directory and are no longer used. Move these into a separate directory, branch, or delete them.

Large subset of commands for BW and B2W2 are missing and make scripting impossible. The command generator should be run against those games.

Windows start fixed at top right of screen with no breathing room. This should be left up to the native window manager.

Hi guys, thanks for making this nice repo; really helpful. I have managed to do the decompression automatically by using the following code (C++):

	static constexpr u32 blzStart = 0xDEC00621;
	static constexpr u64 blzMarker = 0x2106C0DEDEC00621;

	usz offset = usz_MAX;

	for (u64 *start = in.begin<u64>(), *end = in.end<u64>(); start + 1 < end; start = (u64*)((u32*)start + 1))
		if (*start == blzMarker)
			offset = usz(start) - usz(in.add());

	if (offset == usz_MAX || offset <= 4)
		EXCEPTION("Marker not found. Probably uncompressed");

	offset -= 8;

	u32 end = in.at<u32>(offset);

       //Other decompression stuff

in is the arm9 buffer.

I know that this is not python, but I hope it can be of any help in porting it if you at some point decide to do so (I saw a TODO, so I thought I should post this). Only tested it on HGSS, so it might not always work (since you seem to check two separate u16s from the u32s instead of the whole u32s, which my scan doesn't do).

Creating a new Platinum project using PPRE on Linux Mint 18.2 doesn't work. The terminal output complains about not being able to find a config.json file.