projectriff / stream-client-go Goto Github PK

The current integration tests install k8s and riff for testing. These tests should be lighter weight.

With cloud-event support, the Subscribe() method no longer returns the headers passed by the Publish() call.
re-instating the functionality results in the case not being preserved and hence the failure:

--- FAIL: TestSimplePublishSubscribe (0.33s)
    client_test.go:80: headers not equal. expected map[H1:V1 H2:V2], but was: map[h1:V1 h2:V2]

if we change this type from StreamClient to Stream, and the corresponding NewStreamClient to NewStream (and the package could also change from "client" to "stream"), the user experience would be more focused on each stream as opposed to constructing multiple "client" instances when interacting with multiple streams. The Stream type would then include the Publish and Subscribe functions, which logically feel like they belong to the stream itself.

The Makefile uses protoc, but doesn't describe what it is or how to install it. It looks like CI would fail if the pkg/serialization/riff-serialization.pb.go or pkg/liiklus/LiiklusService.pb.go targets were run.