Giter VIP home page Giter VIP logo

Comments (6)

ignacionelson avatar ignacionelson commented on May 27, 2024

How about the rest of the templates? Are they working for you?

from projectsend.

bwiessneth avatar bwiessneth commented on May 27, 2024

I can confirm what @tsumaru720 said! I created custom templates for the actions

New client (welcome): Does not work
New user (welcome): Works
Password reset: Works

I haven't tested the other templates though. I am using version r582.

Edit:

It does work when the option to use the custom Header/Footer is set.

I am no expert when it comes to PHP, nor have I really looked into this project's structure but I think the error is caused by this line:

$body_check = (!defined('EMAILS_HEADER_FOOTER_CUSTOM') || EMAILS_HEADER_FOOTER_CUSTOM == '0') ? '0' : EMAILS_CLIENT_BY_USER_USE_CUSTOM;

(Taken from https://github.com/ignacionelson/ProjectSend/blob/master/includes/classes/send-email.php#L108)

The EMAILS_HEADER_FOOTER_CUSTOM lead me to activate the custom Header/Footer option and then it worked. But if I compare this statement with the other statements a few lines below I think this might be a wrong variable name.

from projectsend.

szobi avatar szobi commented on May 27, 2024

This bug is still there.

I substituted EMAILS_CLIENT_BY_USER_USE_CUSTOM for the appearances of EMAILS_HEADER_FOOTER_CUSTOM in line 108 of the file includes/classes/send-email.php (see comment of @bwiessneth above).

After that the custom email template for new a client created by user works as expected.

from projectsend.

lenamtl avatar lenamtl commented on May 27, 2024

Could you update to the latest version and let us know if this bug is still present?

from projectsend.

bwiessneth avatar bwiessneth commented on May 27, 2024

@lenamtl Hi, thanks for the fix! I tested with the latest version and it works as intended!

from projectsend.

mschop avatar mschop commented on May 27, 2024

Closing this issue, as this seems to be resolved.

from projectsend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.