projectweekend / angular-peity Goto Github PK

Hello,
I'm trying to use the line-chart to make a monitor for cpu usage but the data didn't get updated when it changed.

I found that the watcher works when I update some elements of an array, but doesn't work when push or shift to the array.

I checked the source code and found that at line 39-41

      var watcher = scope.$watch('data', function(){
        span.textContent = scope.data.join();
        jQuery( span ).change();
      });

The watcher doesn't have params objectEquality. So I changed it to

      var watcher = scope.$watch('data', function(){
        span.textContent = scope.data.join();
        jQuery( span ).change();
      }, true);

And it works, maybe the objectEquality params should be added to the watcher?

Please upload the package on npm please, thanks!

In the bower.json peity is written piety.
e.g. in order for bower to be able to automatically include this script
"main": "angular-piety.js",
should be
"main": "angular-peity.js",

Hi. Thanks for the project.

I am trying to make a pie-chart but the data does not get updated when it changes. See plunkr for demo
https://plnkr.co/edit/7rtX5mfDQYw8B2UFxbE2

Please add this to your directive:

var OptsWatcher = scope.$watch('options', function () {
    jQuery(span).peity(chartType, options);
}, true);

scope.$on('$destroy', function () {
    watcher();
    OptsWatcher();
});