proman21 / samd-dma Goto Github PK

Hi,

Thanks for writing this library. It will save me a ton of time. It looks like maintaining this library isn't the highest on your priority list right now, which is totally fine. I just wanted to post something here for anyone else who might come across it.

Right now, the Storage types are composed of arrays of TransferDescriptors. The Storage type should be 16-byte aligned, but neither it nor TransferDescriptor has #[repr(align(16))]. I believe that means proper alignment is not guaranteed. Am I misunderstanding at all?

Also, the Storage types are not repr(C) either. Is that acceptable, because they are composed of exclusively repr(C) arrays? Or should they also have repr(C)?

Thank you for putting together an awesome library!

We've been talking about it over on the atsamd channel, and we are definitely keen in getting native support for DMA into atsamd-hal. I was wondering if we could get your blessing in merging this code into atsamd-hal?

Its likely we'll try to track the embedded-dma traits, but given youve already done a ton to get the DMAC to dance your tune, it would be awesome to be able to base off your work.