Giter VIP home page Giter VIP logo

wp-pronamic-pay-icepay's People

Contributors

remcotolsma avatar rvdsteege avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

wp-pronamic-pay-icepay's Issues

Error 'Country is invalid'

ICEPAY requires a country when starting a payment. We currently determine the country in the following way:

  1. billing address country
  2. logged in user: language setting from user profile
  3. browser language setting (Accept-Language header) if it contains the 'country part' (e.g. US for en-US, but ignoring nl)
  4. site language from general settings

With for example our built-in forms, a user that is not logged-in and uses en-US as browser language and using site language nl_NL will not be able to pay because of an error:

Country is invalid

Can we improve upon this?

Suggestion from customer:

Of een extra feature in de plugin zelf om de country code met de hand te zetten op de site taal te overriden?

Internal Help Scout ticket: https://secure.helpscout.net/conversation/2138120837/25131

This issue could possibly be resolved with #1.

Latest version ICEPAY API?

Leo
Ik kreeg vanmiddag de vraag of we de laatste versie van de Icepay API al gebruiken…
Geen idee hoeveel gebruikers we daarvan hebben. Maar wel goed om in te gaten te houden.

Remco
Kregen we die vraag telefonisch of per e-mail?

Leo
Slack (R●●●●●● van D●●●●●●●) waar ik vorige week klant naar heb doorverwezen.

Leo
Gaat om website https://●●●●●●●●●●●●●●●●●●●●●●●.nl/ die een licentie bij ons afneemt.

I've checked and we're currently using a deprecated library.
https://github.com/icepay/icepayhttps://github.com/ICEPAY/deprecated-i

if it ain't broke, don't fix it

😏

ICEPAY is not a very popular payment provider within Pronamic Pay, if there are concrete issues we can of course update this.

Repository `github.com/ICEPAY/deprecated-i` is `private` - Failed to download `icepay/icepay` from dist

@rvdsteege and GitHub actions run into an issue installing the icepay/icepay package:

Failed to download icepay/icepay from dist: The "https://api.github.com/repos/ICEPAYdev/icepay/zipball/0c517325a6fd55edf64fadfd50eacf044fb6055e" file could not be downloaded (HTTP/2 404 ):
{"message":"Not Found","documentation_url":"https://docs.github.com/rest"}
    Now trying to download from source
  - Syncing icepay/icepay (2.5.3) into cache
Error: Failed to clone https://github.com/ICEPAYdev/icepay.git via https, ssh protocols, aborting.
- https://github.com/ICEPAYdev/icepay.git
  Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-ICEPAYdev-icepay.git'...
  remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.
  remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.
  fatal: Authentication failed for 'https://github.com/ICEPAYdev/icepay.git/'
- [email protected]:ICEPAYdev/icepay.git
  Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-ICEPAYdev-icepay.git'...
  Warning: Permanently added the ECDSA host key for IP address '[140](https://github.com/pronamic/wp-pronamic-pay/runs/7188699564?check_suite_focus=true#step:4:141).82.112.4' to the list of known hosts.
  [email protected]: Permission denied (publickey).
  fatal: Could not read from remote repository.
  Please make sure you have the correct access rights
  and the repository exists.
In Git.php line 484:
  Failed to clone https://github.com/ICEPAYdev/icepay.git via https, ssh prot  
  ocols, aborting.                                                             
  - https://github.com/ICEPAYdev/icepay.git
    Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gi  
  thub.com-ICEPAYdev-icepay.git'...                                            
    remote: Support for password authentication was removed on August 13, 202  
  1. Please use a personal access token instead.                               
    remote: Please see https://github.blog/2020-12-15-token-authentication-re
  quirements-for-git-operations/ for more information.                         
    fatal: Authentication failed for 'https://github.com/ICEPAYdev/icepay.git
  /'                                                                           
  - [email protected]:ICEPAYdev/icepay.git                                        
    Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gi  
  thub.com-ICEPAYdev-icepay.git'...                                            
    Warning: Permanently added the ECDSA host key for IP address '140.82.112.  
  4' to the list of known hosts.                                               
    [email protected]: Permission denied (publickey).                             
    fatal: Could not read from remote repository.                              
    Please make sure you have the correct access rights                        
    and the repository exists.                                                 
install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/pronamic/wp-pronamic-pay/runs/7188699564?check_suite_focus=true

I couldn't reproduce this issue, but I think that's because I'm a contributor to the repository in question.

Maybe time to work on the following issue?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.