protocollabs / mapago Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 415 KB

Reference implementation using Command Line Interface written in Go

Makefile 2.43% Go 91.86% Shell 2.06% Python 3.65%

mapago's People

Contributors

Watchers

Forkers

monfron

mapago's Issues

Implement TCP throughput in maparo-pulser

QUIC-GO: Access unexported fields

some of the quic go fields are not exported
we need to access them in order to save the socket as in the other measurement modules
for example the session struct is used to close the QUIC connection:
https://github.com/lucas-clemente/quic-go/blob/6dc4be9f4e2db98f5b68886887f1a5644ff138da/session.go#L73

server failed to operate - crashes

error message:

Closed network detected!
handleTcpConn goroutine called
panic: interface conversion: error is *errors.errorString, not *net.OpError

goroutine 35 [running]:
github.com/protocollabs/mapago/measurement-plane/tcp-throughput.(*TcpMsmtObj).tcpServerWorker(0xc000188000, 0xc000186120, 0xc0001860c0, 0x1b58, 0x1, 0xc00016c0f0, 0xc00018a1d0)                                                              
        /home/pfeifer/src/code/go/src/github.com/protocollabs/mapago/measurement-plane/tcp-throughput/server.go:149 +0x7bf                                                                                                                    
created by github.com/protocollabs/mapago/measurement-plane/tcp-throughput.NewTcpMsmtObj
        /home/pfeifer/src/code/go/src/github.com/protocollabs/mapago/measurement-plane/tcp-throughput/server.go:74 +0x382

Port Maparo Pulser to Mapago

After porting both implementation should behave compatible over the air - if not something strange happens: the protocol specification war not error free or an implementation bug.

Make install does not build

go install mapago-client.go 
go install: no install location for .go files listed on command line (GOBIN not set)

Why does it call go install? Should call go build ...

Please: wrote a full example in the README.md how to install and build the package. Inculding how to setup GOPATH. New users (not aware of go) should copy and paste the shell commands and execute them. At the end the executable should be generated.

README wrong

There is no wrong:

cd $GOPATH/github.com/protocollabs/mapago

/home/pfeifer/go/src/github.com/protocollabs/mapago

make install
go build -ldflags "-X github.com/protocollabs/mapago/core.BuildVersion=347e346 -X github.com/protocollabs/mapago/core.BuildDate=2019-03-11T15:26:54+0100" -o mapago cmd/mapago/mapago.go
stat cmd/mapago/mapago.go: no such file or directory
make: *** [Makefile:19: mapago] Error 1

Option for mapago

Just tiny cleanup:

mapago-client -ctrl-addr localhost -ctrl-protocol tcp -msmt-type tcp-throughput

should be

mapago-client -ctrl-addr localhost -ctrl-protocol tcp -module tcp-throughput

Check & Stick with best QUIC Implementations

Check the available Quic Implementations. Answer questrions like:

development activity? Under high dev or outdated?
is the goal IETF QUIC compatibility or still focusing on Google Quic?
- What about interop tests?
if Quic Implementation is written in other language than Go: Implement wrapper!

https://github.com/lucas-clemente/quic-go

Build Failed

@yocto-master:~ $ go get github.com/protocollabs/mapago
# github.com/protocollabs/mapago
go/src/github.com/protocollabs/mapago/mapago-server.go:9:5: CTRL_PORT redeclared in this block
	previous declaration at go/src/github.com/protocollabs/mapago/mapago-client.go:15:5
go/src/github.com/protocollabs/mapago/mapago-server.go:10:5: DEF_BUFFER_SIZE redeclared in this block
	previous declaration at go/src/github.com/protocollabs/mapago/mapago-client.go:16:5
go/src/github.com/protocollabs/mapago/mapago-server.go:12:6: main redeclared in this block
	previous declaration at go/src/github.com/protocollabs/mapago/mapago-client.go:29:6

uuidgen failed

Cannot construct uuid exec: "uuidgen": executable file not found in $PATH

A program should never assume that some other program is installed. It should mentioned in the README that some other packages are required.

BUT: uuid should not be called externally, just use one of the many uuid go libraries, e.g. google uuid, and use these.

mapago will not be platform independent if external programs are used (e.g. how to install uuidgen in windows? uuidgen.exe?

Merge client and server into one exutable

-> mapago

and then again mapago client <argument> and mapago server <arguments> should work again.

QUIC: Handshake Timeout kills Server

Even after an unsuccesful handshake the client sends a msmt stop reply
this message tries to kill SERVER and ACCEPT sock => Error ACCEPT not up yet

Mapago does not build anymore

When I type make the following output:

go build -ldflags "-X github.com/protocollabs/mapago/core.BuildVersion=1cd2689 -X github.com/protocollabs/mapago/core.BuildDate=2019-01-11T21:28:56+0100" -o mapago cmd/mapago/mapago.go
stat cmd/mapago/mapago.go: no such file or directory
make: *** [Makefile:19: mapago] Error 1

Project does not build anymore

When I type make the following output:

go build -ldflags "-X github.com/protocollabs/mapago/core.BuildVersion=1cd2689 -X github.com/protocollabs/mapago/core.BuildDate=2019-01-11T21:28:56+0100" -o mapago cmd/mapago/mapago.go
stat cmd/mapago/mapago.go: no such file or directory
make: *** [Makefile:19: mapago] Error 1

Read and Understand Go Code

Probably irtt has some nice ideas for the rtt module, additionally it provides a nice way to learn go code:

https://github.com/peteheist/irtt

Try to understand why a special go construct was used! Was it the best way, are there any better (read: extendable, better maintainable!) constructs?

Try to dig into the code!

go build -ldflags "-X github.com/protocollabs/mapago/core.BuildVersion=7ccd5de -X github.com/protocollabs/mapago/core.BuildDate=2019-03-09T20:04:02+0100" mapago-server.go
go build -ldflags "-X github.com/protocollabs/mapago/core.BuildVersion=7ccd5de -X github.com/protocollabs/mapago/core.BuildDate=2019-03-09T20:04:02+0100" mapago-client.go
mapago-client.go:14:8: cannot find package "github.com/protocollabs/mapago/measurement-plane/tcp-tls-throughput" in any of:
	/usr/lib/go-1.11/src/github.com/protocollabs/mapago/measurement-plane/tcp-tls-throughput (from $GOROOT)
	/home/pfeifer/src/code/go/src/github.com/protocollabs/mapago/measurement-plane/tcp-tls-throughput (from $GOPATH)
make: *** [Makefile:21: mapago] Error 1

Add final measurement data to MsmtInfoReply

this will solve the "correct" simulation duration
and satisfy the protocol specification

TCP (+ TLS): Socket Send/Receive Buffer configurable via param

add a param for Mapago including sock Buffer size
for TLS its a little bit complicated: No setWriteBuffer option

TCP (+TCP/TLS): Handshake Timeout kills Server

same as with QUIC

Channel must not be touched if later exit is called.

https://github.com/protocollabs/mapago/blob/master/measurement-plane/tcp-throughput/server.go#L119

protocollabs / mapago Goto Github PK

mapago's People

Contributors

Watchers

Forkers

mapago's Issues

Recommend Projects

Recommend Topics

Recommend Org