Non-zero exit code breaks CI compatibility about solhint HOT 13 CLOSED

I will check this as soon as i can
thanks @madlabman for the suggestion

from solhint.

Hey @MaxenceAdnot I will implement this fix as well
Probably next week
solhint community is a fork from protofire solhint
both are open source

We will mantain this original solhint because it is an important part of protofire products

from solhint.

@MaxenceAdnot
@madlabman
Expect new solhint version on Monday

from solhint.

Will merge this
#578
To fix this issue

from solhint.

New version
https://www.npmjs.com/package/solhint

from solhint.

@madlabman
Yes , sorry. You're right
I mean, reports[0] contains all errors from the first contract analyzed
If you have more than one contract this will not provide correct info
Like you said I need to loop through all contracts ( all reports[] )
I will fix it today on my afternoon

Thanks a lot for the feedback !! Really appreciate

from solhint.

FWIW I overhauled the exit codes on solhint-community with:

solhint-community/solhint-community#134 -- to exit early and with a different code if there's a misconfiguration
solhint-community/solhint-community#76 -- to have --quiet not override --max-warnings

from solhint.

FWIW I overhauled the exit codes on solhint-community with:

solhint-community/solhint-community#134 -- to exit early and with a different code if there's a misconfiguration solhint-community/solhint-community#76 -- to have --quiet not override --max-warnings

cool!
Thanks @juanpcapurro for that!

from solhint.

Hello @dbale-altoros

Do you plan to implement this in solhint or should we move to solhint-community ?

from solhint.

Thanks a lot @dbale-altoros

from solhint.

Welp, still doesn't work for me.

Probably, the reason is the following code

if (reports[0].errorCount > 0) process.exit(EXIT_CODES.REPORTED_ERRORS)

should iterate over the all the reports instead.

@dbale-altoros

from solhint.

@madlabman made a new package on npm
whenever you can, please confirm if it is working

from solhint.

@madlabman made a new package on npm whenever you can, please confirm if it is working

LGTM, thank you @dbale-altoros !

from solhint.