proximax-storage / tsjs-xpx-chain-sdk Goto Github PK

Note that calculation inside internal builders are correct, since all txs are announced/confirmed correctly.
TODO: refactor - use just one place for tx size calculation

Need to use changes from proximax-storage/js-xpx-chain-library#14 and adapt tests.

"config" and "upgrade" api routes has been added. Add support for it to the sdk (checkout new swagger.yaml from js-xpx-chain-rest repo).

produces wrong signature rejected by Failure_Signature_Not_Verifiable

Hi,

In the documentation page "Installation from github" , Dependencies section, it says Install java-xpx-chain-sdk which I believe should be Install js-xpx-chain-library.

https://github.com/proximax-storage/tsjs-xpx-chain-sdk/wiki/Installation-from-github

Am I correct ? I can make a pull request with the corrections, if you want.

New name will be tsjs-xpx-chain-sdk.

See go implementation, start here: https://github.com/proximax-storage/go-xpx-chain-sdk/blob/master/sdk/exchange_transaction.go

@melvz complained about cosigners not being notified over partialAdded websocket listener when they are added to the msig account.

It seems the message is already present on the partialAdded websocket channel, but it is filtered out and not returned to the (soon to be) cosignatory listener.

It should be possible to change Listener.ts not to filter that out and return it instead.

When using websocket, newBlock() returns undefined for numTransactions, when it should return a number.

Remove js-xpx-chain-library dependency. Merge latest changes from upstream in the process.

Can I use SDK library to validate an unused address?
I try to use "getAccountInfo" but I can not found it if this address wasn't used.

const mosaicId = new MosaicId([123123,123123]);
const modification = new MetadataModification(
MetadataModificationType.ADD,
"key",
"value"
);
const tx = ModifyMetadataTransaction.createWithMosaicId(
NetworkType.TEST_NET,
Deadline.create(),
mosaicId,
[modification],
new UInt64([0,0])
)
JSON.stringify(tx);

I created a transaction like above and issue was happen. It's seem to be unimplemented ModifyMetadataTransaction in file SerializeTransactionToJSON.

1. Error during build
   RemoveExchangeOfferTransaction.ts:77:12
   MosaicDefinitionTransaction.ts:131:12
   ModifyMultisigAccountTransaction.ts:132:12
   ExchangeOfferTransaction.ts:77:12
   AccountAddressRestrictionModificationTransaction.ts:111:12
   error TS2742: The inferred type of 'toJSON' cannot be named without a reference to '.pnpm/github.com+proximax-storage+tsjs-xpx-chain-sdk@81ef420/node_modules/tsjs-xpx-chain-sdk'. This is likely not portable. A type annotation is necessary.

2. Steps to reproduce the problem.

• Reference tsjs-xpx-chain-sdk#next to other project
• Set declaration = true in the tsconfig.json
  "compilerOptions": {
  ...
  "declaration": true,
  ... }
• Execute command pnpm/npm run build
• Unable to build project

3. Specifications like the version of the project, operating system, or hardware.
   NodeJS: 18+
   Typescript: >4.9.5

missed DTO field change action => aliasAction

$ cat visibility.js
const sdk = require('tsjs-xpx-chain-sdk');

sdk.AggregateTransaction.createComplete(
sdk.Deadline.create(),
[],
sdk.NetworkType.MAIN_NET,
[]);

$ node visibility.js
...visibility.js:3
sdk.AggregateTransaction.createComplete(
^

TypeError: Cannot read property 'createComplete' of undefined
at Object. (.../visibility.js:3:26)
at Module._compile (internal/modules/cjs/loader.js:956:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
at Module.load (internal/modules/cjs/loader.js:812:32)
at Function.Module._load (internal/modules/cjs/loader.js:724:14)
at Function.Module.runMain (internal/modules/cjs/loader.js:1025:10)
at internal/main/run_main_module.js:17:11

Some Rest api fields changed (at least for chain upgrade and chain config txs). Need to update it according to the latest swagger.

1. I install this sdk by: npm install tsjs-xpx-catapult-sdk, have error:

npm ERR! code ENOVERSIONS
npm ERR! No valid versions available for tsjs-xpx-catapult-sdk

npm ERR! A complete log of this run can be found in:
npm ERR!     home/.npm/_logs/2019-06-05T09_34_57_889Z-debug.log

2. And I try to install use: npm install https://github.com/proximax-storage/tsjs-xpx-catapult-sdk.git but have same error above
3. When i check version in www.npmjs.com, it not exist.

Please help me, Thanks.

• request is having UnhandledPromiseRejection in the library, which will give headache to user of newer version of NodeJS
• request is deprecated for some time, it is better to change to another library

there are npm warnings during install - updating nyc solves it, but it breaks coveralls reporting - investigation needed

PageQueryParams is missing from export

Now there is the possibility to:

1. Alice creates the aggregate complete transaction (without other signatures)
2. Alice sends only payload to Others
3. each Other signs the payload and sends signature back to Alice
4. Alice gathers all the cosignatures, creates the aggregate complete transaction again, signs it and announces
   A->B, B->A
   A->C, C->A
   A->D, D->A
   A->announce

If we support appending additional signatures to the signed aggregate complete transaction, also following would be possible:

1. Alice creates and signs the aggregate complete transaction (without other signatures)
2. Alice sends the whole transaction to the next in the chain
3. each chain member receives the partially signed transaction, appends own signature
4. last chain member announces fully signed aggregate complete transaction
   A->B
   B->C,
   C->D,
   D->announce

Merge latest cow additions from upstream.

Update tx versions for 0.6.5 blockchain compatibility, so e2e passes again.

1. Expected behavior and actual behavior.

2. Steps to reproduce the problem.

3. Specifications like the version of the project, operating system, or hardware.

var transaction = _tsjsXpxChainSdk.AccountRestrictionTransaction.createAddressRestrictionModificationTransaction(_tsjsXpxChainSdk.Deadline.create(), _tsjsXpxChainSdk.RestrictionType.AllowAddress, [allowedAddresses], _tsjsXpxChainSdk.NetworkType.TEST_NET);
^

TypeError: Cannot read property 'createAddressRestrictionModificationTransaction' of undefined
at Command.callback (D:/Projects/doc-api/modules/restriction/RestrictWallet.js:76:63)
at normal_reply (D:\xxxxxx\node_modules\redis\index.js:726:21)
at RedisClient.return_reply (D:\xxxxxx\node_modules\redis\index.js:824:9)
at JavascriptRedisParser.returnReply (D:\xxxxxx\node_modules\redis\index.js:192:18)
at JavascriptRedisParser.execute (D:\xxxxxx\node_modules\redis-parser\lib\parser.js:574:12)
at Socket. (D:\xxxxxx\node_modules\redis\index.js:274:27)
at Socket.emit (events.js:198:13)
at Socket.EventEmitter.emit (domain.js:448:20)
at addChunk (_stream_readable.js:287:12)
at readableAddChunk (_stream_readable.js:268:11)
[nodemon] app crashed - waiting for file changes before starting...

taken from here: https://bcdocs.xpxsirius.io/docs/guides/account-restriction/preventing-spam-attacks/

See proximax-storage/go-xpx-chain-sdk#74

The route is the only way how to get list of incoming transactions for an account with unknown public key. Now the support for it is missing in the sdk.

there is wrong path for js-xpx-chain-library dependency in package-lock.json

Implement metadata support, add e2e tests for metadata.

AddExchangeOfferTransaction version has been increased to "2". Currently only relevant for testnet.

I have a connection to websocket, I tried it in different ways and I did not succeed.

I tried it with catch, catch error, try catch and with none of these ways I succeeded

I attach the reference image!

Problem: One of our InnerTransactions have a ModifyMetadataTransaction and using AggregateComplete and sign and recreate the transaction, it returns an transaction type not implemented yet.

Findings: I checked the dist/src/infrastructure/transaction/CreateTransactionFromPayload.js and in the CreateTransaction() function the switch-case does not have the MODIFY_ACCOUNT_METADATA.

Steps to reproduce the problem:
Do an aggregate complete transaction and use metadata modification as one of the inner transactions.

The version field has been changed from two to four bytes. This is a breaking change and needs to be fixed asap.

Default import for MosaicDefinitionTransaction doesn't work, there is probably a circular dependency somewhere.

See proximax-storage/go-xpx-chain-sdk#47 for details.

Please fix NetworkCurrencyMosaic namespace Id, it is suppose to be prx.xpx.

Currently still following NEM cat.currency

It has never been working correctly.

V2 update changed the DTO from REST API, SDK need to update

• linkedAccountKey is missing from AccountInfo model class
• linkedAccountKey not returned from getAccountInfo and getAccountsInfo from AccountHttp