pruizlezcano / comicgeeks Goto Github PK

Looks like LOCG reworked their issue page, and broke the Page and Price values.

It would be nice to have a method that would retrieve the variant issue page, like a method on Issue obj variant_cover field like:

>>> s = locg.issue_info(4090926)
>>> variant0 = s.variant_covers[0].detail()

Haven't thought too hard on this, but it would require modifying Issue Class to take an optional variant id (supplied by the information from from the s.variant_covers[0] url information. Adding this would give the option to get an issue that isn't a thumbnail image, and also expose upc, price, and other issue info.

Attempting to get the data for an issue, and getting the following error:

  File "/home/bpepple/.cache/pypoetry/virtualenvs/barda-fHSUYen5-py3.11/lib/python3.11/site-packages/comicgeeks/classes.py", line 679, in price
    self._get_data()
  File "/home/bpepple/.cache/pypoetry/virtualenvs/barda-fHSUYen5-py3.11/lib/python3.11/site-packages/comicgeeks/classes.py", line 875, in _get_data
    int(counters_data["rating"].replace(",", ""))
ValueError: invalid literal for int() with base 10: 'TBD'

It looks like new issues that haven't had any ratings added shows up as TBD, which causes an issues since the class is only expecting an int value. Should be a reasonably easy fix to check that it's an int before setting the class value.

Was looking at variant covers info, and noticed that the image field is broken due to a change over at LOCG.

>>> s = locg.issue_info(4090926)
>>> s.variant_covers[0]
{'name': "Superman '78: The Metal Curtain #2 Cover B Michael Cho Card Stock Variant", 'url': '/comic/4090926/superman-78-the-metal-curtain-2?variant=8558719', 'image': '#'}

Inspecting the html it looks like it is the following:

<div class="col-lg-4 col-md-2 col-sm-3 col-4 mb-3 text-center  ">
    <a href="/comic/4090926/superman-78-the-metal-curtain-2?variant=8558719" class="d-block mx-1" data-toggle="tooltip"
       title="" data-original-title=" Cover B Michael Cho Card Stock Variant">
        <img class="lazy loaded" src="https://s3.amazonaws.com/comicgeeks/comics/covers/medium-8558719.jpg?1701801688"
             alt="Superman '78: The Metal Curtain #2 Cover B Michael Cho Card Stock Variant" data-ll-status="loaded">
    </a>
</div>                        

Title pretty much explains it all, and it's fairly easy to check:

1. Use a virtualenv and install comicgeeks with pip.
2. In the virtualenv attempt to use comicgeeks and be presented with module missing errors.

If you grab the wheel file from PyPI, and inspect the contents you'll see the main deps aren't included. My guess is your build system is misconfigured, but since I've never used PyScaffold that is only a guess.