Header(s) cannot be included warning-free with `-Wundef` about pspsdk HOT 3 CLOSED

Alternetively, the pspdev.cmake toolchain can add the include paths using -isystem instead of -I

SET(CMAKE_C_FLAGS_INIT "-isystem${PSPDEV}/psp/include -isystem${PSPDEV}/psp/sdk/include -DPSP -O2 -G0") 
 SET(CMAKE_CXX_FLAGS_INIT "-isystem${PSPDEV}/psp/include -isystem${PSPDEV}/psp/sdk/include -DPSP -O2 -G0") 

from pspsdk.

Alternetively, the pspdev.cmake toolchain can add the include paths using -isystem instead of -I

pspsdk/src/base/pspdev.cmake

Lines 12 to 13 in 6192ee8

	SET(CMAKE_C_FLAGS_INIT "-I${PSPDEV}/psp/include -I${PSPDEV}/psp/sdk/include -DPSP -O2 -G0")
	SET(CMAKE_CXX_FLAGS_INIT "-I${PSPDEV}/psp/include -I${PSPDEV}/psp/sdk/include -DPSP -O2 -G0")

becomes

SET(CMAKE_C_FLAGS_INIT "-isystem${PSPDEV}/psp/include -isystem${PSPDEV}/psp/sdk/include -DPSP -O2 -G0") 
 SET(CMAKE_CXX_FLAGS_INIT "-isystem${PSPDEV}/psp/include -isystem${PSPDEV}/psp/sdk/include -DPSP -O2 -G0") 

Unfortunately, testing this yielded the same results. _PSP_FW_VERSION is still being complained about as being undefined with -Wundef. Interestingly though, this is only an issue I can reproduce with cmake. Using the standard build.mak this issue does not occur.

I've gone ahead an made a PR guarding _PSP_FW_VERSION. This probably should have been in place to begin with, so thanks for the report and potential fix suggestions.

from pspsdk.

Alternetively, the pspdev.cmake toolchain can add the include paths using -isystem instead of -I

pspsdk/src/base/pspdev.cmake

Lines 12 to 13 in 6192ee8

	SET(CMAKE_C_FLAGS_INIT "-I${PSPDEV}/psp/include -I${PSPDEV}/psp/sdk/include -DPSP -O2 -G0")
	SET(CMAKE_CXX_FLAGS_INIT "-I${PSPDEV}/psp/include -I${PSPDEV}/psp/sdk/include -DPSP -O2 -G0")

becomes

SET(CMAKE_C_FLAGS_INIT "-isystem${PSPDEV}/psp/include -isystem${PSPDEV}/psp/sdk/include -DPSP -O2 -G0") 
 SET(CMAKE_CXX_FLAGS_INIT "-isystem${PSPDEV}/psp/include -isystem${PSPDEV}/psp/sdk/include -DPSP -O2 -G0") 

Unfortunately, testing this yielded the same results. _PSP_FW_VERSION is still being complained about as being undefined with -Wundef. Interestingly though, this is only an issue I can reproduce with cmake. Using the standard build.mak this issue does not occur.

That's strange. I applied this suggestion in the SDL workflow. Perhaps it only works on the first configuration.

I've gone ahead an made a PR guarding _PSP_FW_VERSION. This probably should have been in place to begin with, so thanks for the report and potential fix suggestions.

Thank you!

from pspsdk.