CMake using the incorect OUTPUT_NAME but stripping. about pspsdk HOT 8 CLOSED

This should be fixed now with #199 being merged now

from pspsdk.

Thanks for submitting an issue!, feel free to create a PR otherwise let's wait for the well versed in cmake for the fix

from pspsdk.

@smb123w64gb what is the problem that was fixed by this change? I just did a quick test and the binary is being stripped just fine with both of these. I see no changes to the result if I change it.

from pspsdk.

@smb123w64gb Please post your CMake invocation here and the relevant part of your CMake files where you call the create_pbp_file macro. Knowing the arguments you passed both to CMake and to the macro will greatly help us reproducing the issue.

from pspsdk.

@sharkwouter I'm not by my computer, but judging by the provided snippet:

$<TARGET_FILE_DIR:${ARG_TARGET}>/${ARG_TARGET}

...manipulating target in a way that makes its output name different can indeed lead to invalid (non-existent) file path passed to the stripper.

In other words, the macro assumes target name is the same as output artifact name.

from pspsdk.

The create_pbp_file sits here. SonyPSP.cmake#L60
Included from RSDKv5/CMakeLists.txt#L71
And this is also called from the game build its self.Sonic-Mania-Decomp/CMakeLists.txt

from pspsdk.

Thanks, I will get back to you soon.

from pspsdk.

I reproduced the issue, applied your suggestion @smb123w64gb of using $<TARGET_FILE:${ARG_TARGET}> and the macro now works for both default and customised OUTPUT_NAME. Relevant MR: #199

from pspsdk.