pswai / ember-cli-react-fork Goto Github PK

I'm using the library and it's working well so far though I'm still working through upgrade bugs and deprecations.

On Ember v3.16, they started deprecating the globals resolver. Instead, they want you to extend from ember-cli-resolver. I believe the package currently imports from ember-resolver, when it should be ember-cli-resolver..

https://deprecations.emberjs.com/v3.x/#toc_ember-deprecate-globals-resolver

I did:
npm i -D ember-cli-react-fork
ember generate ember-cli-react

then I cut an pasted your say-hi.jsx into app/components

went to an .hbs and added:
{{say-hi name="Alex"}}

this is what I get in the console:
Uncaught (in promise) Error: Assertion Failed: Failed to create an instance of 'component:say-hi'. Most likely an improperly defined class or an invalid module export.
at assert (vendor.js:41802:15)
at FactoryManager.create (vendor.js:7211:82)
at Proxy.create (vendor.js:6932:20)
at CurlyComponentManager.create (vendor.js:13142:31)
at Object.evaluate (vendor.js:56115:25)
at AppendOpcodes.evaluate (vendor.js:54420:19)
at LowLevelVM.evaluateSyscall (vendor.js:57921:22)
at LowLevelVM.evaluateInner (vendor.js:57877:14)
at LowLevelVM.evaluateOuter (vendor.js:57869:14)
at VM.next (vendor.js:58994:24)
at VM._execute (vendor.js:58978:23)
at VM.execute (vendor.js:58949:28)
at TryOpcode.handleException (vendor.js:58058:23)
at UpdatingVMFrame.handleException (vendor.js:58294:31)
at UpdatingVM.throw (vendor.js:57989:18)
at Assert.evaluate (vendor.js:55566:17)
at UpdatingVM._execute (vendor.js:57972:16)
at vendor.js:57943:63
at runInTrackingTransaction (vendor.js:60670:21)
at UpdatingVM.execute (vendor.js:57943:51)
at RenderResultImpl.rerender (vendor.js:58322:10)
at vendor.js:17044:57
at RootState.render (vendor.js:17010:11)
at vendor.js:17336:18
at inTransaction (vendor.js:57754:9)
at InteractiveRenderer._renderRoots (vendor.js:17316:37)
at InteractiveRenderer._renderRootsTransaction (vendor.js:17368:14)
at InteractiveRenderer._revalidate (vendor.js:17410:12)
at invoke (vendor.js:62370:16)
at Queue.flush (vendor.js:62261:13)
at DeferredActionQueues.flush (vendor.js:62458:21)
at Backburner._end (vendor.js:62992:34)
at Backburner._boundAutorunEnd (vendor.js:62661:14)

Hi Folks - we've been using this plugin in our ember project and it works really well.
One issue I just noticed may be unique to the way we're using it, so this may not be a true issue but was hoping for some discussion (if you don' t want this as clutter, I'll understand if you close)

We re-export some react components from a library and use them directly in ember. We have some react components that expect other react components as children - for example menus. For these we pass in a list of the items to the component and within one Ember component compose a bunch of React components. The problem is that for each Ember component wrapping React, we get a style tag in the header with all of the React component styles used in that Ember component. Anyone know if it's possible to disable that behavior?