ptarmiganlabs / butler-app-duplicator Goto Github PK

Describe the bug
Let's say a user directory of for example TESTDIR is defined in the config file, and a owner of the newly created app of USER1 is specified.

If user TESTDIR/USER1 does not have permissions to access the template apps, the app duplicator will not be able to verify that the specified app really is tagged as a template app, with a failed app creation as a result.

This is how the app duplicator was designed, but the drawback is that all users using the tool must also be given access to the template apps. This will result in those template apps showing up in the Hub, potentially confusing users.

Expected behavior
This is a really a design change:

• Use internal user accounts when interacting with the QRS APIs.
• As a final step change owner of the created app, to the user specified in the call to the app duplicator's API.

Upgrading Sense Enterprise to Feb 2020 or beyond means that the Sense certificates will be recreated. The new certs must be exported and made available to Butler app duplicator.
Failing to do so will cause Butler app duplicator to stop working.

Update docs to highlight the above.

Current version is vulnerable to https://nodesecurity.io/advisories/577.
It affects this repo as it uses qrs-interact, which in turn (eventually) uses lodash.
Fix by bumping the lodash version used in qrs-interact.

There are indications in some systems (but not all, strangely enough) that the Sense user sessions created by the app duplicator as part of the calls to the QRS are not properly released. Instead, these sessions stick around and just accumulate over time.

The strange thing is that this behaviour has been reported on a few Sense systems, but others work just fine (the sessions are automatically released after the new app has been created, as they should). Could be a bug in the app duplicator, but it also be something in Sense itself causing this.

Sometimes template apps take a significant time to reload, and usually there is no need to reload template apps right after they have been created (at least not if the template app's load script is kept intact).

=> Make it optional (by means of a config paramter) to reload the newly created apps

Request is deprecated, Axios is new, shiny and supported.
Axios is also used by most other Butler tools => make things consistent over the entire Butler family.

When trying to duplicate an app that is a template, but the new owner does not have permissions to, the following error occurs.
Seems "BadRequestError" is no longer a valid way of returning an error when using Restify.

error: Duplication error 5: Received error code: 403::No permission to duplicate the app.
Unhandled rejection TypeError: restify.BadRequestError is not a constructor
at qrsInteractInstance.Post.then.catch.err (/nodeapp/index.js:666:30)
...

Describe the bug
When running in a multi-arch (amd64 and arm64) k8s cluster, containers fail to start on arm64 nodes.

Expected behavior
Containers should automatically start on amd64, arm64 or arm nodes.

Solution idea
The issue might be caused by the variant field in the manifest. It seems that the manifests of other (working) multi-arch images Docker images don't have that variant field. Might be worth removing it as a first attempt at resolving the issue.

FROM ….
LABEL maintainer="Göran Sander [email protected]"
LABEL description="lorem ipsum"

An optional feature that (if enabled) will send recurring status messages to the log files, stating how the service has been running, how much memory it is using etc.

If a user clicks the Create app buttons a second time, before the app duplicator has finished, a "Can't set headers twice" error will be thrown.

Possible solution: Disable button until app duplication is done. Then enable it again.

It would be nice to get some basic info about the underlying Qlik Sense environment written to the Butler logs, whenever Butler is started.
Things such as overall Sense version, QIX engine version, info about the hardware Sense is running on etc.

Add a configurable (URL, frequency etc) heart beat that is sent from the app duplicator to an external monitoring tool.
This will make it easy to monitor the uptime of the app duplicator.

https://www.repostatus.org/

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Datasource	Name	Replacement PR?
npm	request

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update dependency chai to v5
• Update dependency restify to v11
• Update dependency supertest to v7
• Update dependency winston-daily-rotate-file to v5
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency ws to v8.17.1 [SECURITY]
• Update dependency config to v3.3.12
• Update dependency jshint to v2.13.6
• Update dependency chai to v4.5.0
• Update dependency enigma.js to v2.14.0
• Update dependency mocha to v10.7.3
• Update dependency restify to v8.6.1
• Update dependency winston to v3.14.2
• Update dependency winston-daily-rotate-file to v4.7.1
• Update node Docker tag to v16
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Improve CI/CD process to be more automated, including multi architecture support.

In the spirit of minimalism, we should only run/expose the APIs really necessary from apps.
Thus make it possible to disable the Docker healtcheck server

Would offer user a more structured way of examining the REST API of Butler App Duplicator.