Entry Incentives and Exit Taxes about cw-ics721 HOT 6 CLOSED

@shanev - I think the outstanding question here is what to do with the exit tax funds. I figure we could either burn them, transfer to an address, or use them to fund entry inventives.

I think exit tax funds can be just sent to an address which could be a burn address, a DAO, or whatever. It would be great to support community pools as well, but I don't think it's worth supporting something that will end up being legacy soon (since they will get module accounts eventually).

from cw-ics721.

I say try to undo the transfer on any kind of panic.

To do this, we'll need two things:

1. The on_entry hook should be dispatched as SubMsg::reply_on_error with a gas limit. If an error occurs during the callback, an ACK-FAIL should be returned instantly, thus failing the transfer.
2. The hook receiver should be able to remove itself. In practice, this means that the entry incentives module should have a message that its manager can execute which removes it from the ICS-721 contract. This lets us "turn off" entry incentives if needed.

from cw-ics721.

@shanev - I think the outstanding question here is what to do with the exit tax funds. I figure we could either burn them, transfer to an address, or use them to fund entry inventives.

from cw-ics721.

Another important point while implementing this is to take care of how the entry-incentives module panics. If the ICS-721 on_entry hook panics, the NFT being transferred will be stuck until a timeout occurs. We need to design:

1. How does the entry-inventives module handle being out of funds?
2. Are there any inputs that could cause it to panic?
3. If an unexpected panic occurs, what should we do?

from cw-ics721.

1. How does the entry-inventives module handle being out of funds?

Can it check its balance before the transfer and throw an error?

2. Are there any inputs that could cause it to panic?
3. If an unexpected panic occurs, what should we do?

I say try to undo the transfer on any kind of panic.

from cw-ics721.

This is currently being solved in Ark's new proxy repo, example of check paid is here:
https://github.com/arkprotocol/ics721-plus/blob/main/packages/cw-ics721-outgoing-proxy/src/lib.rs#L140
repo here: https://github.com/arkprotocol/ics721-plus/

from cw-ics721.