publiclab / publiclab.editor Goto Github PK

I'm trying to reproduce this in a test, but I can't seem to... maybe this is more about what exactly triggers history storage? Right now it's on 10 second interval, but also on if the textarea 'changes':

https://github.com/publiclab/PublicLab.Editor/blob/master/src/PublicLab.History.js#L20

      $(_editor.richTextModule.options.textarea).on('change', function() {

and of course if it's changed from the last editor entry.

create a related: powertag that notifies related authors?

A moddable module which can guide you through making tags, which could simply be some common options displayed as buttons, or could be some more involved kind of menu or prompt.

@ebarry -- do you think that if we had an interface like this, that the tags it creates should be added to the basic "tags" input, in part so that people can "see behind the curtain" and be able to add tags themselves without the guide (or to a pre-existing page?)

Or do you think that might result in a confusing amount of tags in the tag input? It might end up looking like this:

I made some bold text at https://publiclab.org/editor into a header using the Cmd-D shortcut.

I was left with:

**

### Session note-taking**

I did:

1. created the bold text by typing and selecting and using cmd-B
2. selected it and turned it into a heading using cmd-D
3. repeated the cmd-D twice more to get a smaller heading
4. switched to Markdown mode

I was able to reproduce this at https://publiclab.github.io/PublicLab.Editor/examples/, too.

I believe this may be an issue to fix in domador? https://github.com/bevacqua/domador

This is not an urgent feature, but could result in just having to pass an element (or jQuery-type selector, like div#editor) instead of needing a whole bunch of specifically named elements as in the example pages.

This is also not super easy in older browsers, due to template literals being a pretty new feature: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

(apart from just doing it messily, building in jQuery node by node in older JS syntax)

...but could be done with https://babeljs.io/, perhaps with help from https://github.com/trueadm/t7

What happened just before the problem occurred

When starting a new post in the rich editor, you can see a red bar or box where errors would show, even though there aren't any errors.

Relevant URLs

https://publiclab.org/editor/ (requires login) or in this repository's demo?

Relevant lines of code

Here's where we check if there are errors: https://github.com/publiclab/PublicLab.Editor/blob/master/src/PublicLab.Errors.js#L14

Here's where the errors are displayed in a <div>: https://github.com/publiclab/PublicLab.Editor/blob/master/src/PublicLab.Errors.js#L16

So really, we should add a test that checks that the errors are not shown when there is no _errors.options included in the editor's constructor. The test could go here:

https://github.com/publiclab/PublicLab.Editor/blob/master/spec/javascripts/errors_spec.js

I uploaded this small image to the main image box on the Editor:

and the preview showed this:

But this is not a real problem because once published, the lead image was not actually tiled.

Really enjoying the new Editor, just wanted to point out that when toggling between the rich mode and markdown (which i did to try to get more control on how some code bits were displaying), resulted in some loss of formatting when back in rich mode.

The automated indentations were still present, but the numbers all reset to 1. It was easy to fix this by placing my cursor after the automatic number at the start of my text, and click backspace and the numbering caught up to where it should have been:

Draft questions:

We're looking for design feedback from folks new to Public Lab. Have you ever posted on PublicLab.org?

If you have one, what is your username?

Rate https://publiclab.org/post from 1: confusing to 5: intuitive

Comments and thoughts on the design and interface?

Specific things that caused you trouble or were confusing?

Rate https://publiclab.org/editor/examples/ from 1: confusing to 5: intuitive

Comments and thoughts on the design and interface?

Specific things that caused you trouble or were confusing?

What is an authoring interface you've used that you liked? That you didn't like?

to use megamark or something, maybe with syntax highlighting

display rendered markdown but then overwrite it using megamark in JavaScript

We sometimes get very short posts by people with no context or background, and perhaps just a MapKnitter map or Spectral Workbench image. We should try to draw them out more in describing what they're sharing and why. Apart from better templates, we could make an alert popup or something like that, that can say something like:

You haven't written very much -- add a bit more detail or background to help people understand what you're sharing and why.

We'd have to be sure this doesn't affect questions, which can be very short. Or maybe set the threshold for questions to be shorter.

I'm using the publiclab.org/editor and it's very nice.

When i drag and drop images, the image URL prompt displays for a short time, i think while the image is uploading -- it seems to request information like adding a link URL but the issue i am reporting is that this prompt disappears before i can actually read it or type into it. I had to be fast even to capture this screenshot of it!

Actually, if i had wanted to add a link to the image, and i had missed my chance during this flash, i am not sure how to get this popup back.

Please note we are preparing to participate in Google Code-in, and have reserved this issue for GCI participants - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

GCI students are requested to go through the conversation and understand it before jumping to the implementation. The conversation will help them to debug it.

maybe break out into independent submodule?

What is happening here is all body text logs are being saved in the local cookie store but as you can see in this line https://github.com/publiclab/PublicLab.Editor/blob/master/src/PublicLab.History.js#L194 they are appended with a display:none property in a p tag. All these logs can be toggled with a log button that displays the date on which they were made. But the button isn't displayed until a day gets over after you use the editor for the first time. See these lines: https://github.com/publiclab/PublicLab.Editor/blob/master/src/PublicLab.History.js#L185-L192. After a day it shows the toggle button and logs can be seen henceforth.

Please note we are preparing to participate in Google Code-in, and have reserved this issue for GCI participants - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Not sure if this is a Woofmark behavior or what? https://github.com/bevacqua/woofmark

but it could be tested in that editor to see; it may be due to a # link of some kind being triggered on pressing enter after inputting the URL in the popup form.

of usernames, tagnames, research notes by id or title (like github issues?) -- maybe another syntax like P# or $ or [title]?

bevacqua/woofmark#30 (comment)

https://publiclab.org/notes/warren/09-01-2016/calibrating-your-spectrometer-in-spectral-workbench returned a "Request URI too long" error which went away after I reduced the length of the body text. I think it's submitting via GET, and we should submit via POST.

figure out where most time is spent

Temporary fix is to limit to 10 past versions, and/or one version per title if more than 1 day old?

https://sliptree.github.io/bootstrap-tokenfield/

(or http://bevacqua.github.io/insignia/)

went with tokenfield, much progress!!!

could conflict with History module

popover-style, or sticking to bottom?

maybe move it to the top, since it keeps jumping around. Pin it to the t op, esp. for mobile use?

Hello, while trying to get a hang of the codebase I noticed a relatively insignificant issue that the tooltip-arrow wasn't positioned properly in the example page. Can get rid of the arrow simply by adding .tooltip.bottom .tooltip-arrow { display:none;} to the css.

hypothetically.

[graph|xxxxxx] with Chart.js?

Or potentially https://github.com/JoelOtter/jutsu/

test at https://publiclab.org/editor

I've got this one!

with opacity gradient. Consider absolute positioning for others.

pending bevacqua/bureaucracy#3

Then ensure that the name field can be set via options; name is currently uploads:

Content-Disposition: form-data; name="uploads"; filename="Screenshot 2016-08-15 at 10.46.03 AM.png"

If the form Submission fails due to some reason such as not entering the title or body (or if any validation check fails at database side) the entire html template is appended to the url as response text and no appropriate error message is displayed. This is what I am getting for a unsuccessful submission while integrating it with a Rails server(Testing with the plots code).

I haven't seen my drafts saving... i think we're deleting from the wrong end of the array at:

https://github.com/publiclab/PublicLab.Editor/blob/master/src/PublicLab.History.js#L59-L60

        _history.log = _history.log.slice(0, 20);

Hmm, tested this out and it looks ok --

Maybe this is more about what exactly triggers history storage? Right now it's on 10 second interval, but also on if the textarea 'changes':

https://github.com/publiclab/PublicLab.Editor/blob/master/src/PublicLab.History.js#L20

      $(_editor.richTextModule.options.textarea).on('change', function() {

and of course if it's changed from the last editor entry.

When returning to rich mode from a brief dive into markdown mode, the carriage returns (which i placed after each numbered item to add white space between the bottom of the screenshot from the top of the next instruction) were lost. Not a big deal here, easy to work around this, but reporting it because it was unexpected behavior

a JSON object which is parsed with editor.format(editor.data)

Please note we are preparing to participate in Google Code-in, and have reserved this issue for GCI participants - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

When i try to move an image that has already been uploaded/embedded, it gives this error although there's nothing really wrong with the image:

Hi, i'm not sure if this is a bug, but i'm just pointing out that when i add images to my instructional steps, which are in a numbered list, i have to get out of the list in order for images to successfully upload. Once uploaded, i can easily indent an image as part of a numbered step.

if just typing numbers (i.e. not using the list widget), then dragging and dropping works although it loses how far you may be scrolled down the page -- it bumps you up to the top of your posting.

http://openrov.dozuki.com/Guide/Guide+6+-+Finishing/68

Autocompletion with horsey is just not working reliably in this library. But @cheneyshreve and @ViditChitkara have implemented some amazing autocompletion on the plots2 project using the atwho library:

• https://github.com/ichord/At.js/ (underlying atwho, pure JS)
• publiclab/plots2#2925 (reference implementation on plots2)

@cheneyshreve has documented the at.js lib working in concert with our Woofmark rich text editor module. So this should work! We'd love some help getting this up and running.

at https://publiclab.org/wiki/authoring-help#Images

I see a little problem in the No of steps left displayed in the bottom right corner of the editor. It shows just fine when you fill out the body first and then the title. But if you fill out the title first and then the body (which is the usual order of posting a note) it shows 1 of 2 steps left. Also the Submit button is disabled until then so basically you can't post despite filling out all the title and body. Only after you write something in the title again all steps are shown to be complete and the Submit button is enabled.

Like at https://publiclab.org/post --

https://github.com/publiclab/PublicLab.Editor/blob/master/src/modules/PublicLab.TitleModule.Related.js#L50 adds a + button to each "related" post when typing a title.

That's set with:

function fetchRelated() {

    show([
      { id: 1, title: 'A related post',       url: '/', author: 'eustatic'},
      { id: 2, title: 'Another related post', url: '/', author: 'stevie'},
      { id: 3, title: 'A third related post', url: '/', author: 'bsugar'}
    ]);

  }

We should make it possible to set an action for when you press Add + -- perhaps an API method like:

function addRelated(item) {
  editor.tagsModule.value('notify:' + item.author + ',' + editor.tagsModule.value())
}

However, this would depend on publiclab/plots2#646 -- worthwhile, but for now, perhaps we wait.

For example history or autocompletion settings

possibly with new PL.Editor({ errors: <json> })