puckipedia / dos2unix Goto Github PK

Just wanted to mention this doesn't work with binary files.

Technically correcting line endings should be done only when the following character is also a newline. This style just skips writing whenever the character is a carriage return or newline.

State is required when reading character by character....
State 1: Look for carriage return
write if the character isn't.
State 2: Look for newline
write the consumed carriage return if it isn't. (as to not corrupt binary data)
write only the newline if it is.
send non-matching character through main loop again with state 1. (for binaries containing CRCRLF)

Your implementation will clobber files that have valid CRLFs inside of binary data, such as PNG. The state based conversion will not corrupt a PNG where as your method will.

Just figured I'd share in case others run into this.