puppetlabs / puppetlabs-puppet_data_service Goto Github PK

Describe the Bug

PDS-migrations fails to run and errors exit 2 on 2019.8.9

Notice: /Stage[main]/Puppet_data_service::Server/File[/etc/puppetlabs/pds/pds-server.yaml]/content: content changed '{md5}3f86759b0cb5871c4a018831388010ba' to '{md5}4a0422f4ea78b238b80ac6858cb42d76'
Info: /Stage[main]/Puppet_data_service::Server/File[/etc/puppetlabs/pds/pds-server.yaml]: Scheduling refresh of Service[pds-server]
Notice: /Stage[main]/Puppet_data_service::Server/Exec[pds-migrations]/returns: [output redacted]
Error: [command redacted] returned 2 instead of one of [0]
Error: /Stage[main]/Puppet_data_service::Server/Exec[pds-migrations]/returns: change from 'notrun' to ['0'] failed: [command redacted] returned 2 instead of one of [0] (corrective)
Notice: /Stage[main]/Puppet_data_service::Server/Service[pds-server]: Dependency Exec[pds-migrations] has failures: true
Warning: /Stage[main]/Puppet_data_service::Server/Service[pds-server]: Skipping because of failed dependencies

Expected Behavior

pds-migrations should run correctly

Steps to Reproduce

Run the install on a 2019.8.9 server

Environment

PE 2019.8.9

Additional Context

Disccused with Edwin who verified this is an issue he experienced

Describe the Bug

PDS URI's hierarchy in hiera.yaml is not honoured.

Expected Behavior

As we have below hierarchy followed... Expectation is first it needs to find the Key values from nodes/%{trusted.certname} level if not found go to os/%{operatingsystem} and then to common.

hierarchy:

• name: "Puppet Data Service"
  data_hash: puppet_data_service::data_hash
  uris:
  • "nodes/%{trusted.certname}"
  • "os/%{operatingsystem}"
  • "common"
    options:
    on_config_absent: "continue"

Steps to Reproduce

Steps to reproduce the behavior:

1. Lets say Create a <Key/Value> at common level (i.e., pds-cli hiera upsert common abc::package_version -v '"10.0.0.1"'
2. When you do puppet lookup abc::package_version --explain it is trying to lookup from all the levels but unable to find the key.
3. If you give at first level say nodes/%{trusted.certname} or keeping common level at the top it works fine.

Environment

• PDS Module Version - 0.1.0
• Platform [e.g. Ubuntu 18.04]

Additional Context

As i see there is an issue with data_hash.rb file under ../modules/puppet_data_service/lib/puppet/functions/puppet_data_service/ at line number 63 we are trying to return the parsed_options which is not allowing to go to next level and accepted a top level declared only... Is this intentional?