pvdberg1998 / pnet Goto Github PK

Would you welcome a PR with a gradle build file for this?

I like the PNet API design.
I saw this.
https://github.com/PvdBerg1998/PNet/blob/master/src/test/java/nl/pvdberg/pnet/BenchmarkTest.java
It is only tested on 1 client 1 server.
Multi client 1 server has not been tested.
In the case of multiple clients, depending on the implementation, a large number of threads are created, or if some communication is delayed, the whole is delayed.
How much performance do you get?

Hi,

I have created one server and two clients.

Server:

server = new PlainServer();
server.setListener(new ServerListener());
server.start(10240);

Client 1:

client1 = new PlainClient();
client1.setClientListener(new ClientListener());
client1.connect("localhost", 10240);

Client 2:

client2 = new PlainClient();
client2.setClientListener(new ClientListener());
client2.connect("localhost", 10240);

I can send a packet from Client 1 to the Server with:

packet1 = new PacketBuilder(Packet.PacketType.Request).withInt(10).withString("test").withBoolean(true).build();
client1.send(packet1);

But I'm not sure on how send this packet to Client 2? 🤔
(ServerListener() and ClientListener() are both an implementation of PNetListener)

Hi, I had a pretty hard time to debug some code in my handlePacket method and I wonder if there is any reason why you are using e.getMessage() instead of just passing the exception to print the entire stack trace?
That would make things much easier to debug, so for example instead of
logger.error("Error in listener thread: {} : {}", e.getClass(), e.getMessage()); just use logger.error("Error in listener thread: {} : {}", e.getClass(), e);

Performance gain : usage of coroutines vs threads per client