pwasem / openui5-sdk-docker Goto Github PK

I cloned and runned your project using docker-compose up -d --build and it gave this error:

yarn install v1.19.1
[1/4] Resolving packages...
[2/4] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "http://nexus.wdf.sap.corp:8081/nexus/repository/build.releases.npm/fastify/-/fastify-2.9.0.tgz: getaddrinfo ENOTFOUND nexus.wdf.sap.corp".
info If you think this is a bug, please open a bug report with the information provided in "/home/node/app/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
ERROR: Service 'openui5_sdk' failed to build: The command '/bin/sh -c yarn install --production' returned a non-zero code: 1

Hi,

fellow tinkerer @rsletta runs this tool https://github.com/rsletta/get_openui5_latest_url#readme to provide a direct link to the latest UI5 version.
Would be cool to use this one as the default setting during docker build when no specific ui5 version was provided.

Just .02€, v.

Hi,
thank you for the Dockerfile.
Wouldn't it make more sense to use ENV instead of ARG in Dockerfile and .env?

ENV UI5_VERSION 1.67.1
ENV UI5_FILENAME openui5-sdk-${UI5_VERSION}.zip
ENV UI5_URL https://github.com/SAP/openui5/releases/download/${UI5_VERSION}/${UI5_FILENAME}

Best regards,
Florian