Create classes for artifacts, annotations, and emojis about pybuildkite HOT 13 CLOSED

I left a comment on #10 that applies to all PRs =)

from pybuildkite.

So it looks like the docstrings aren't filled out. Also you'll want to pull in the recent master as you have some merge conflicts.

from pybuildkite.

Okay, on it.

from pybuildkite.

Artifacts: #10
Annotations: #11
Emojis: #12

Tell me if it is all OK.

from pybuildkite.

Left a comment on the first one that likely applies to all of them. Thanks @KristoferSoler!

from pybuildkite.

Oh I forgot, each of these need to be added to the buildkite class in order to be invoked

from pybuildkite.

Oh I forgot, each of these need to be added to the buildkite class in order to be invoked

OKay, 😎 give a minute.

from pybuildkite.

Left a comment on the first one that likely applies to all of them. Thanks @KristoferSoler!

What did you mean?

from pybuildkite.

So it looks like the docstrings aren't filled out. Also you'll want to pull in the recent master as you have some merge conflicts.

Yeah xD I face that just right now.

from pybuildkite.

Wow, now I see you put a lot of info in docstring. I will update all my branches. 🙇‍♂️ give me some minutes my dude.

from pybuildkite.

List of branches done:

• Annotations ➡️ #14
• Artifacts ➡️ #15
• Emojis ➡️ #16

Now should be all ok. @pyasi tell me if you need any change.

I will edit this as making the changes.

from pybuildkite.

Hey @pyasi , do you need anything more?

from pybuildkite.

@KristoferSoler We're all set for this issue, thanks! Tests are always welcome =)

from pybuildkite.