Generalize `Objective` about napari-micromanager HOT 8 CLOSED

yeah this just came up with @fdrgsp this week. agree it needs fixing. don't have a strong opinion. do you have a preference?

from napari-micromanager.

can this #43 (get objectives from an objective group configuration ) be an option?

from napari-micromanager.

Maybe we should do 3 with a fallback of 1 where we also check for other common names.

For checking names I would propose starting with this regex:

import re
re.compile("(Nosepiece|Objective|obj)s?", re.IGNORECASE)

from napari-micromanager.

Oh actually it should be 1 with a fallback of 3 so that users can override the devices via a config group

from napari-micromanager.

Yep I'm fine with these. @fdrgsp, you could incorporate the regex checking into #43. (i.e. instead of if cfg == "Objectives": you'd do:

import re
# top of file
OBJ_PTRN = re.compile("(Nosepiece|Objective|obj)s?", re.IGNORECASE)

def _refresh_objective_options(self):
    for cfg in self._mmc.getAvailableConfigGroups():
        if OBJ_PTRN.match(cfg):
            self.objective_comboBox.clear()
            self.objective_comboBox.addItems(self._mmc.getAvailableConfigs(cfg))
            return

we could also add a hook in loadSystemConfiguration that tries to determine what the "Objective" is going to be using 1 with a fallback of 3 so we don't have to search each time

from napari-micromanager.

adding the fallback would then be adding a second for loop (only reachable if we didn't already return) that would look like this:

        for device in self._mmc.getLoadedDevicesOfType(pymmcore_plus.DeviceType.StateDevice):
            if OBJ_PTRN.match(device):
                ...

from napari-micromanager.

can this be closed?

from napari-micromanager.

I believe so

from napari-micromanager.