Comments (3)
Triggering Bedevere via events will create something like this:
but worse. The whole approach needs to be redesigned.
from bedevere.
To modify configure.ac, contributors need to use the https://github.com/tiran/cpython_autoconf Docker image. However, Windows users are out of luck; for my contributions I need to use a throwaway GitHub Actions workflow.
I am not sure for this suggestion.
If user didn't regenerate configure file, how do we can belive that user verify the change in their local environment?
from bedevere.
Fortunately, Check if generated files are up to date
already prints a diff that perfectly solves the underlying issue without adding anything to Bedevere:
if test -n "$changes"; then
echo "Generated files not up to date."
echo "Perhaps you forgot to run make regen-all or build.bat --regen. ;)"
echo "configure files must be regenerated with a specific version of autoconf."
echo "$changes"
echo ""
git diff --staged || true
exit 1
fi
Thus closing.
from bedevere.
Related Issues (20)
- Add PR links to the issue HOT 5
- Improve formatting of PR links added to issues HOT 1
- bedevere-bot does not have 2FA enabled HOT 10
- Bedevere check for issue number is faulty
- Automate adding linked-pull-request symbol under "Milestones" column of the issue tracker HOT 2
- Bedevere shouldn't add "awaiting review" label on draft PRs HOT 3
- Renaming issues/PRs incorrectly changes `awaiting change review` and `awaiting merge` to `awaiting review` HOT 3
- Incorrect bedevere transition HOT 2
- Incorrect bedevere transition (the sequel) HOT 6
- Bedevere failed to create "needs backport to 3.12" label
- Bug: 500 error when bedevere received "commit.pushed" webhook events. HOT 1
- Bedevere should label "awaiting merge" after a core review HOT 3
- Update NEWS message HOT 2
- Bedevere doesn't say "thank you" for making the requested changes anymore HOT 3
- Is Bedevere retired? HOT 2
- Shouldn't Sir classify changes in test modules by "tests" label? HOT 1
- Add docs label for PRs that touch Doc/tools/.nitignore HOT 9
- Link to devguide when lint fails HOT 12
- Copy over topic-* labels to backport PRs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bedevere.