Giter VIP home page Giter VIP logo

Comments (3)

arhadthedev avatar arhadthedev commented on August 16, 2024

Triggering Bedevere via events will create something like this:

image

but worse. The whole approach needs to be redesigned.

from bedevere.

corona10 avatar corona10 commented on August 16, 2024

To modify configure.ac, contributors need to use the https://github.com/tiran/cpython_autoconf Docker image. However, Windows users are out of luck; for my contributions I need to use a throwaway GitHub Actions workflow.

I am not sure for this suggestion.
If user didn't regenerate configure file, how do we can belive that user verify the change in their local environment?

from bedevere.

arhadthedev avatar arhadthedev commented on August 16, 2024

Fortunately, Check if generated files are up to date already prints a diff that perfectly solves the underlying issue without adding anything to Bedevere:

          if test -n "$changes"; then
            echo "Generated files not up to date."
            echo "Perhaps you forgot to run make regen-all or build.bat --regen. ;)"
            echo "configure files must be regenerated with a specific version of autoconf."
            echo "$changes"
            echo ""
            git diff --staged || true
            exit 1
          fi

Thus closing.

from bedevere.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.