Comments (3)
I think the main change is on here:
https://github.com/python/bedevere/blob/main/bedevere/stage.py#L104
Here, we're handling the "pull_request.opened" webhook event, and apply either the awaiting review
or awaiting core review
label.
Since the webhook event sends the draft
status as True or False, we can use that to determine whether or not we should apply the label when the PR is opened.
if event.data["draft"] is False:
# apply label
We should also add apply the label when the PR was changed from draft
to ready to review
. So we may need to add the decorator @router.register("pull_request", action="edited")
.
from bedevere.
And I guess we should also handle the situation when the PR was changed from "ready to review" back to the "draft" state.
from bedevere.
I'm happy to try to make this change myself (maybe with some guidance as I never touched this codebase before :) )
from bedevere.
Related Issues (20)
- Improve formatting of PR links added to issues HOT 1
- bedevere-bot does not have 2FA enabled HOT 10
- Bedevere check for issue number is faulty
- Teach Bedevere to suggest regenerated `configure` file HOT 3
- Automate adding linked-pull-request symbol under "Milestones" column of the issue tracker HOT 2
- Renaming issues/PRs incorrectly changes `awaiting change review` and `awaiting merge` to `awaiting review` HOT 3
- Incorrect bedevere transition HOT 2
- Incorrect bedevere transition (the sequel) HOT 6
- Bedevere failed to create "needs backport to 3.12" label
- Bug: 500 error when bedevere received "commit.pushed" webhook events. HOT 1
- Bedevere should label "awaiting merge" after a core review HOT 3
- Update NEWS message HOT 2
- Bedevere doesn't say "thank you" for making the requested changes anymore HOT 3
- Is Bedevere retired? HOT 2
- Shouldn't Sir classify changes in test modules by "tests" label? HOT 1
- Add docs label for PRs that touch Doc/tools/.nitignore HOT 9
- Link to devguide when lint fails HOT 12
- Copy over topic-* labels to backport PRs
- `News entry file name incorrectly formatted` when moving a news entry HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bedevere.