Giter VIP home page Giter VIP logo

Comments (3)

Mariatta avatar Mariatta commented on August 16, 2024 2

I think the main change is on here:

https://github.com/python/bedevere/blob/main/bedevere/stage.py#L104
Here, we're handling the "pull_request.opened" webhook event, and apply either the awaiting review or awaiting core review label.

Since the webhook event sends the draft status as True or False, we can use that to determine whether or not we should apply the label when the PR is opened.

if event.data["draft"] is False:
# apply label

We should also add apply the label when the PR was changed from draft to ready to review. So we may need to add the decorator @router.register("pull_request", action="edited").

from bedevere.

Mariatta avatar Mariatta commented on August 16, 2024 1

And I guess we should also handle the situation when the PR was changed from "ready to review" back to the "draft" state.

from bedevere.

itamaro avatar itamaro commented on August 16, 2024

I'm happy to try to make this change myself (maybe with some guidance as I never touched this codebase before :) )

from bedevere.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.