ql-io / ql.io-ebay-mp-apis Goto Github PK

The readme is pretty thin on getting started details, so I tried as described, to run ./bin/start.sh. That fails promptly with Error: Cannot find module './node_modules/.bin/ql.io.app' so I ran npm install. That tried to install dependencies, but failed miserably, outputting a looong list of random errors whatnot. Server wouldn't started, so I ran npm install again, this time trying to capture the log output. That didn't work, but somehow npm install finished without an error, and I could even start the server.

Next I even managed to find a QL snippet to test, though the reference to the test directory isn't great, since there's a lot of testing code surrounding the interesting snippets.

After editing config/dev.json I even got a finding request working.

Something I haven't figured out yet: How do I set the site id to search only EBAY-DE? There's a property under the trading key, but I haven't set any of those properties yet, since I'm currently only using the finding API.

Is there any reason why there aren't any routes for the trading API in this repository? I'm putting together routes for a few trading calls and can contribute them back, if there's interest.

Finding and trading configs use "appname", shopping uses "appid". Debugging a copy&paste error where shopping requests fails because I only had "appname" wasn't much fun.

Would help to make those properties consistent. The eBay developer account page uses "AppID" as the label, so should probably use "appid" everywhere.

Currently http responses (e.g. /ebay/finding/version) are returned with Transfer-Encoding:chunked, that causes issues when proxiny ql.io, e.g. nginx.

I actually managed to get nginx to proxy it anyway, using these directives:

location /ebay {
    proxy_pass http://localhost:3000;
    proxy_redirect off;
    proxy_buffering off;
    chunked_transfer_encoding off;
    proxy_set_header Host $host;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;

}

Afaik ql.io uses node's http module, which enables Transfer-Encoding:chunked when no Content-Length header is set.

All the tables in the shopping folder have the gateway hardcoded to "http://open.api.ebay.com/shopping?", instead of using the gateway configured in dev.json.

Try to use the finding API routes, I've hit a roadblock due to the lack of support for item filters. findItemsAdvanced doesn't take itemFilter into account at all, while findItemsByKeywords only supports a single itemFilter, instead of the 1-n that the actual Finding API supports, e.g. itemFilter(0).name=HideDuplicateItems&itemFilter(0).value=true&itemFilter(1).name=ListingType&itemFilter(1).value=Auction&itemFilter(2).name=MaxDistance&itemFilter(2).value=10.