Giter VIP home page Giter VIP logo

Comments (8)

Maria-Bordunova avatar Maria-Bordunova commented on June 12, 2024 1

I see, thank you. We will fix it as soon as possible. I hope today the fix'll be available:pray:

from flutter-sdk.

Maria-Bordunova avatar Maria-Bordunova commented on June 12, 2024

Hi, @royston-c !
Thank you for the detailed report 🙌. We'll check the scenario and come back in the near future.

from flutter-sdk.

royston-c avatar royston-c commented on June 12, 2024

I just want to reiterate. This happens on EVER call to get offerings. This isn't an edge case.

Note: I tested the below and everything works:

  static Future<QOfferings> offerings() async {
    final offeringsString = await _channel.invokeMethod<String>(Constants.mOfferings);

    // looks like the library returns an empty object from other methods
    if (offeringsString == null) {
       return QOfferings(null, <QOffering>[]);
    }

    final Map<String, dynamic> decodedOfferings = jsonDecode(offeringsString!);

    return QOfferings.fromJson(decodedOfferings);
  }

from flutter-sdk.

royston-c avatar royston-c commented on June 12, 2024

I'm happy to create a PR myself if they'll be any delay. I was hoping to wrap up my null safety migration for my app today :)

from flutter-sdk.

Maria-Bordunova avatar Maria-Bordunova commented on June 12, 2024

Oh, it would be great! We really appreciate your contribution! 🤝

from flutter-sdk.

royston-c avatar royston-c commented on June 12, 2024

Sure. I'll get on that now.

from flutter-sdk.

Maria-Bordunova avatar Maria-Bordunova commented on June 12, 2024

@royston-c Thank you once again. We published new release version 3.0.1 with your fixes 🎉

from flutter-sdk.

royston-c avatar royston-c commented on June 12, 2024

thanks. I've just tested it and it seems to be fixed with 3.0.1 👍

from flutter-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.