quantumlemur / supybot-plugins Goto Github PK

Hello,

I saw this code in Timebomb, but you may do it in other plugins:
if self.debug:
self.irc.reply('I just created a bomb in %s' % channel)
You shouldn't use IRC for debugging purpose; log.debug has been created for that.

Best regards,
ProgVal

Apparently it's not liking the defining of another class in the main class. Maybe it has to do with the python version? (My server is using python 2.4)

Error returned on plugin load ("load Trivia")

Hello,

I saw you never use irc.error(), but irc.reply(), even if it is used for an error.
You should use irc.error(), because it offers a more standart handling for errors, including nested commands.

Best regards,
ProgVal

Hi,

This line is buggy:
if relay.channelRegex.match(channel) and relay.networkRegex.match(irc.network) and (len(triggerMsg.args[1] < 1 or relay.messageRegex.search(triggerMsg.args[1]))):

Look at that: len(triggerMsg.args[1] < 1

Best regards,
ProgVal

Hello,

The sendToOthers function handles joins, parts, quits, and privmsg in the same way, but it shouldn't.

(Un)fortunatly, quits, and some parts, have a quit/part message, so it is relayed as a normal message, but it shouldn't.
Joins or part without message just raise an exception (the "IndexError: tuple index out of range" on line 182 I told you)

Best regards,
ProgVal

Hello,

I got this two error messages :
http://paste.pocoo.org/show/329148/
http://paste.pocoo.org/show/329149/

Best regards,
ProgVal

Hi,

In that code, is that hard-coded user's nicks?
if s == 'xen':
num = 5
elif s == 'splurk':
num = 5

Thank you in advance,
ProgVal

Hello,

Me and a friend have installed LinkRelay on our own bot, and @LinkRelay nicks doesn't work on both.
No reply, no error message, no log but "XXX called linkrelay nicks".

Best regards,
ProgVal

Hello,

In the run() method of ListenerThread, there is no time.sleep(); so, if an IOError is raised each time the try block is runned, it would use the CPU at 100% until self.active goes to false.

Best regards,
ProgVal

Hi,

Why did you comment doQuit()?

Thank you in advance,
ProgVal