r-js / blasjs Goto Github PK

Hi Jacob,
I came across your library and I couldn’t find a couple of functions in the library.
dposv
dpotrs
dorgqr
dgeqrf
Are you still interested in developing this library? I would be happy to fund the functions I need.
Regards,
Isaac
P.S. BTW, the library is really awesome!

This package seems to fail when run under pnpm it, seemingly due to a missing dependency on jest-matcher-utils referred to from jest-extension.ts. Attempted to fix in #15, but perhaps the type import should be removed instead.

 FAIL  lib/l3/complex/csyrk/__test__/test.ts
  ● Test suite failed to run

    lib/packages/__test__/jest-extension.ts:4:41 - error TS2307: Cannot find module 'jest-matcher-utils' or its corresponding type declarations.

    4 import type { MatcherHintOptions } from 'jest-matcher-utils';

Do you want to contribute on webgpu or wasm versions? Create an issue and lets discuss.

Originally posted by @jacobbogers in #15 (comment)

Just discovered this library, how does this project compare to Ndarray-blas?
Ndarrays are strided arrays for easier tensors manipulations.

Would be great to see perf comparisons between the two.

Hi,

First of all thanks for all this work. I have a question about

is there a reason why you would use undefined behavior here?

In the first round base + (i - rowStart) == -1 which result in a undefined behavior and then skips by one and turns the im = 0.

if this is the purpose wouldn't it be better to wrap it around an if statement to make it more clear what the desired behavior would be?

isamax
icmax

Reference BLAS

         IX = 1
         DMAX = DABS(DX(1))
         IX = IX + INCX
         DO I = 2,N
            IF (DABS(DX(IX)).GT.DMAX) THEN
               IDAMAX = I
               DMAX = DABS(DX(IX))
            END IF
            IX = IX + INCX
         END DO
      END IF
      RETURN

They should be
_isamax = i; and _icamax = i;

I found this bug when I did a rewrite of the generate-fixtures to get complete test coverage.

These two test are wrong max should be max: 3.

        case1: {
            desc: 'isamx n=3, incx=2',
            input: {
                n: 3,
                cx: {
                    re: [1, 2, 3, 4, 5, 6]
                },
                incx: 2,
            },
            output: {
                max: 5
            },
        },

        case1: {
            desc: 'icamx n=3, incx=2',
            input: {
                n: 3,
                cx: {
                    re: [1, 2, 3, 4, 5, 6],
                    im: [7, 8, 9, 10, 11, 12]
                },
                incx: 2,
            },
            output: {
                max: 5
            },
        },