r1cm3d / aws-poc Goto Github PK

Describe the bug
I tried to use something similar to this snippet:

	_, err := svc.CreateBucket(&s3.CreateBucketInput{
		Bucket: aws.String(bucketName),
	})

But it seems that CreateBucket or CreateBucketInput is not working because it did not change bucket param path.

To Reproduce
Steps to reproduce the behavior:

1. Go to s3_test.go file
2. Run TestUploadIntegration
3. See CreateBucket returning an InvalidBucketName error with 400 as status code

Expected behavior
Create the bucket without any error.

https://github.com/codecov/example-go
https://codecov.io/gh/ricardomedeirosdacostajunior/aws-poc

The current infra package has just sqs files. It should be extract to its own sqs package.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/custom-service-endpoints#localstack

Move infrastructure package to pkg and act internal as domain

https://goreportcard.com/report/github.com/ricardomedeirosdacostajunior/aws-poc

I create this worker struct to work around this problem. Maybe I could use Embedding to do that.

The gofmt command has a -r flag that provides a syntax-aware search and replace, making large-scale refactoring easier

So, I should apply it and check whether the names are good.

It could be added after create domain package.

By mistaken, I use this structure:

err := someFunc();
if err != nil {
// treatment here
} 

I could use:

if err := someFunc(); err != nil {
// treatment here
} 

In this case, err just exists in the block context.

Verify the possibility of use testify mocks rather than those implemented. If it's not possible, extract mocks to a file.

Loading json file is not working in TravisCI pipeline

Describe the bug
make run-dep target in Makefile creates the container that will used in local environment. However, while localstack is initializing terraform tries to apply its scripts before localstack is ready.

To Reproduce
Steps to reproduce the behavior:

1. Run make clean;
2. Run make run-dep;

Expected behavior
Create all AWS resources

There are a lot of duplicated code in this file. It should be refactored.

There is no need to create a struct that has no data to implement an interface. I can do that, creating a func type. As in the Effective Go