ArrayList<Enum> nav args crashing about compose-destinations HOT 6 CLOSED

@stanleyguevara please try 1.10.2. Thank you again so much for reporting this! 👍

from compose-destinations.

Hi @stanleyguevara !

I have no idea how this was like this for so long, thank you so much for taking the time to report 🙇
Indeed there's an issue specifically with ArrayList.

I will fix it and release a new version, today still. In the meantime, as you found, Array work fine until that is done!

from compose-destinations.

Hey @raamcosta just to let you know there is still a problem in 1.10.2 when passing an ArrayList and the list is empty.
When the list is empty I get this crash:

java.lang.StringIndexOutOfBoundsException: String index out of range: -2
at java.lang.String.substring(String.java:2064)
at java.lang.String.subSequence(String.java:2107)
at com.ramcosta.composedestinations.navargs.primitives.arraylist.DestinationsEnumArrayListNavType.parseValue(DestinationsEnumArrayListNavType.kt:31

Not sure why. My current solution is to make it nullable, and pass null when empty.

from compose-destinations.

Hi @ehammo

I cannot reproduce this on my machine. Can you tell me more about the nav arguments of this destination? Is it the only nav arg?
It would also be nice if you could go into DestinationsNavController.navigate method and place a breakpoint in there and tell me how the route parameter looks like.

Thank you!

from compose-destinations.

This is how the code looks like:

data class MyCustomNavArg(
val optionalString: String? = null,
val listOfEnum: ArrayList = ArrayList(),
) : Parcelable

data class AnotherDataClass(
val optionalString: String? = null,
val listOfEnum: List = listOf(),
) : Parcelable

@destination(navArgsDelegate = MyCustomNavArg::class)
@composable
fun MyCustomDestination(...

@destination
@composable
fun AnotherDestination(
navigator: DestinationsNavigator,
) {
data: AnotherDataClass = AnotherDataClass(optionalString = "String")
navigator.navigate(
MyCustomDestination(
optionalString = data.optionalString,
listOfEnum = ArrayList(data.list)
)
)
}

Route looks like this:
"my_custom_destination?optionalString=String&listOfEnum="

from compose-destinations.

I still can't reproduce it.

Here is the exact code I'm using.

@Parcelize
data class MyCustomNavArg(
    val optionalString: String? = null,
    val listOfEnum: ArrayList<Stuff> = ArrayList(),
) : Parcelable

@Parcelize
data class AnotherDataClass(
    val optionalString: String? = null,
    val listOfEnum: List<Stuff> = listOf(),
) : Parcelable

@Destination(navArgsDelegate = MyCustomNavArg::class)
@Composable
fun MyCustom(navArgs: MyCustomNavArg) {
    Text(navArgs.toString())
}

@Destination
@Composable
fun Another(
    navigator: DestinationsNavigator,
) {
    val data = remember { AnotherDataClass(optionalString = "String") }
    LaunchedEffect(data) {
        delay(500)
        navigator.navigate(
            MyCustomDestination(
                optionalString = data.optionalString,
                listOfEnum = ArrayList(data.listOfEnum)
            )
        )
    }
}

The route is my_custom?optionalString=String&listOfEnum=[]. I am navigating to the "AnotherDestination" which then automatically navigates to "MyCustomDestination" after 500ms.

Stuff is a enum class.

from compose-destinations.