rackspace-cookbooks / chef-sugar-rackspace Goto Github PK

13 files inspected, 44 offenses detected.

We should probably move this project into rackerlabs or some place where all rackers can help maintain it, if it's not just going to be a side project.

Rubocop should run in CI, should fail when it finds violations.

It looks like calls to rackconnect? are failing when used on non-cloud, with error "must have rackconnect ohai plugin installed". It appears that the plugin is installed, the box just isn't a cloud box. Thus, rackconnect? should probably just return false.

Also, if node['rackspace']['foo'] or any other key is set, then it fails as well.

      def rackconnected?(node)
        return false unless node.key? 'rackspace'
        if node['rackspace'].key? 'rackconnect'
          return node['rackspace']['rackconnect']['enabled']
        else
          fail 'must have rackconnect ohai plugin installed'
        end
      end

We should be able to set node['rackspace']['foo'] and still have rackconnect? not raise or fail. Probably the source of rackspace-cookbooks/rackspace_support#8.

Once it's made generally available, should we move to using that data instead, and potentially submit a PR upstream to chef-sugar proper that supports the same kind of functionality for all cloud providers, e.g. best_cloud_ip_for() and cloud_networks()?

See also https://github.com/AutomationSupport/fastfood-templatepack/issues/14.

Currently, chef-sugar-rackspace depends on chef-sugar ~> 2.0, but chef-sugar released a v3 back in March. We should bump chef-sugar-rackspace's dependencies to the newer one at some point.

Seems this needs to be updated since a specific compile_time value is now required or we get a deprecation warning.

[2015-09-21T19:32:13+00:00] WARN: chef_gem[chef-sugar-rackspace] chef_gem compile_time installation is deprecated [2015-09-21T19:32:13+00:00] WARN: chef_gem[chef-sugar-rackspace] Please set compile_time falseon the resource to use the new behavior. [2015-09-21T19:32:13+00:00] WARN: chef_gem[chef-sugar-rackspace] or setcompile_time true on the resource if compile_time behavior is required.