Giter VIP home page Giter VIP logo

pingprovements's People

Contributors

radiden avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar

pingprovements's Issues

Mod causes issues with PingOrdering

PingOrdering seems to only make the selected minion act when the ping is removed. With this mod, the selected minion waits for a very long time for the ping to be removed, even if the move/attack ping has already been issued. It's possible to set the enemy ping duration to ~1 second to somewhat get around this, but this also affects actual enemy pings, which isn't ideal.

Suggested fixes:

  1. Have the mod treat minion pings differently from enemy pings.
  2. Have the minion ping be removed from the minion after issuing a move/attack ping.
  3. Allow the maximum amount of enemy pings at once to be configurable.

Wrong Version Uploaded?

The file on Thunderstore seems to still be 1.7.0, which quietly fails to load with the dlc. It throws an error that I see with a lot of mods from before the latest patch changed up modding stuff, as more-or-less expected. Checked through both r2modman and manually downloading from Thunderstore just in case there was a difference for some reason.
LogOutput.log

[Suggestion] Teleporter Ping Duration

I haven't tested it yet, but I assume Teleporter ping uses the InteractablePingLifetime duration. Personally I would be happy if there where an additional special option with the teleporter. This config would have 3 option:

  1. Default - this would just take the time of InteractablePingLifetime as it works now (this would be the default)
  2. Multiplier - this would multiply the value of InteractablePingLifetime by a set number, so for example if the InteractablePingLifetime is 30 and the multiplayer is 3, then the ping duration for Teleporter would be 90 (30 x 3).
  3. Pernament - pretty self explanatory - this would make ping for teleporter permanent.

Can't ping the same object twice in a row

I can not ping an object again until I have used up all my pings on other objects or locations first.

For instance, ping an enemy and wait for the ping to disappear. Attempting to ping this enemy again does nothing. Sure, the same issue is in the base game, but there the next ping will show up successfully. With this mod, it does not matter how many times I press the ping button. I instead have to ping randomly all over the place first before it allows me to ping that enemy again.

Note: I am playing multiplayer with a friend. We both have this issue.

Suggested fixes: (Either would make me happy)

  1. Fix the bug and let me ping the same object again.
  2. Add a setting that lets me use the base game's pinging behavior. It wouldn't have multiple pings per player, but I'm not that interested in that feature anyway.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.