rafaelhdr / meteor-google-charts Goto Github PK

I've installed this plugin via atmospherejs. But after installation I can't render charts. The error shown in console is:

A Parser-blocking, cross-origin script, https://www.google.com/uds/?file=visualization&v=1.0&packages=corechart%2Cgauge%2Ctimeline, is invoked via document.write. This may be blocked by the browser if the device has poor network connectivity.

As per: https://developers.google.com/web/updates/2016/08/removing-document-write

The call to Google Charts only occurs in loadScript. As a result, it does not support creation of charts after the page has loaded.

Solution: All you need to do is take the second definition of drawChart (the one that actually does all the work) and define it outside of the loadScript function (you'll need to rename one of the drawCharts to avoid name collisions). Then that function can be called at any time.

Could you please add a license so that others can use this package? Publishing software without a license means that anyone attempting to use it would be in violation of copyright. If you could please add a MIT or other distribution-friendly license, that would be appreciated!

Thanks

Finally got around to attempting to use this package via atmosphere today. Notices that the version downloaded is missing the "timeline" addition.

Wondering if something else needs to be changed for this new version of the package to be recognised on atmosphere? I noticed that I did not make any changes to packages.json when I did the PR. Do you think package.json should also be bumped up with a new version number?

Kind regards
James

This is due to Meteor no longer providing Underscore per default. See the thread in the forum for some info.

Hello, I am running Meteor 1.4 under Windows10 64 bits edition.

The installation of the package simple failed even if I run the command with the administrator rights.
That works fine under linux plateforme

C:\Users\Domi\Documents\meteor\testdb>meteor add rafaelhdr:google-charts
C:\Users\Domi\AppData\Local.meteor\packages\meteor-tool\1.4.1_1\mt-os.windows.x86_32\isopackets\ddp\npm\node_modules\meteor\promise\node_modules\meteor-promise\promise_server.js:165
throw error;
^

Error: ENOENT: no such file or directory, open 'C:\Users\Domi\AppData\Local\Temp\mt-toqi9g\os\rafaelhdr:google-charts.js'
at Error (native)

is the module compliant with windows ?

thx

no mention of how to click on the chart

Their is a packages console log, this should really be removed or allow this to come up only in a debug mode.