Giter VIP home page Giter VIP logo

reliabilipy's People

Contributors

pmdscully avatar rafaelvalero avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

Forkers

pmdscully

reliabilipy's Issues

Bug: `n_factors_f` is not being used in FactorAnalyzer model fitting.

Bug:

n_factors_f is not forwarded to the FactorAnalyzer modelling process for group factors; and therefore the code always fits for 3 factors only. - Here's an example of code and outputs in colab.

Fix: add 1 line (an extra argument) into the call for group factors, around lines 183-185, as below:

        self.fa_f = FactorAnalyzer(rotation=self.rotation_fa_f,
                                   method=self.method_fa_f,
                                   n_factors=self.n_factors_f, # <--- This line.
                                   is_corr_matrix=True)
        self.fa_f.fit(self.correlations_matrix)
        self.fa_g = FactorAnalyzer(rotation=None,
                                   is_corr_matrix=True,
                                   method=self.method_fa_g,
                                   n_factors=1)

I have recompiled the .pyc and tested this. It should be a straightforward fix.

P.s. - Thanks for your work on this project, I've included your citation in our upcoming report. All the best.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.