can't specify Unordered for custom Dimension about dimensionaldata.jl HOT 6 CLOSED

Yeah const instead.

And we make traits to detect plot axis rather than inheritance like we have now.

We can also make show nicer and not show the Dim{} part most if the time.

from dimensionaldata.jl.

Damn thats a bug with keyword handling maybe.

Btw im thinking to delete the custom dims anyway soon and switch to just Dim...

from dimensionaldata.jl.

oh no! i find the concise syntax of custom dims nice. but, i guess it would be (syntactically) equivalent to define const Foo = Dim{:Foo} instead of using DimensionalData.@dim Foo, right? show would display Dim{:Foo} but programmatically you could still use e.g. fill(NaN, Foo(1:3, order=Unordered())).

from dimensionaldata.jl.

Ah this is just a macro scope issue. Will fix.

from dimensionaldata.jl.

thanks for fixing! but, i'm wondering now whether to use const or @dim. what are the tradeoffs? is there a discussion somewhere on your plan to remove custom dims?

from dimensionaldata.jl.

It shouldn't make much difference - I will just change the macro to create the const definition and it will keep working with very little disruption for most things. I'm hoping e.g. Rasters.jl wont need to do anything with the update even though it uses the @dims macro.

from dimensionaldata.jl.