Comments (3)
Thanks for filing this, I guess I never use reverse on multidimensional arrays without dims
. It should totally be fixed.
As a rule anything like that this isn't exactly the same as Base AbstractArray
behavior is a bug rather than something intentional. A DimArray
should be a conforming AbstractArray
except in cases where AbstractArray
would error - e.g. by using a Dimension
in dims
for `reverse. (bugs like this exist because we add methods to try and make the dimensions do sensible things to match the array behaviour, and sometimes don't get the implementation right)
I will try to enforce this when the BaseInterfaces.jl array interface is more complete, its just hard to comprehensively test every part of the AbstractArray
interface currently.
from dimensionaldata.jl.
You're welcome, and seems like a quick fix. May I submit a PR?
from dimensionaldata.jl.
Absolutely!
from dimensionaldata.jl.
Related Issues (20)
- Feature Request: pass fill value (single element) to `DimArray` HOT 8
- Support plot mutation with global Axis HOT 10
- Towards a nicer Makie recipe HOT 10
- Would it be useful to have Not() as a selector? HOT 4
- Makie extension throws StackOverflowError when dimensions have Unitful units HOT 4
- Dimensions of Observable(dd) are ignored in Makie 0.21 HOT 10
- Displaying one-dimensional `DimArray` does not quite work in Pluto HOT 8
- Performance of `broadcast_dims` on `DimStack` vs `DimArray` HOT 1
- Remove if VERSION checks HOT 1
- Plotting deprecations in tests
- Reduce number of warnings in tests HOT 1
- How can I create a 2D array using broadcasting? HOT 1
- MethodError: no method matching `copy(::X{LinRange{Float64, Int64}})`
- Selection of multiple surrounding pixels around a position HOT 4
- Add CodeCov upload token to fix codecov HOT 4
- friction in dimension-specific `mean` of a `groupby` HOT 4
- FR: Make `broadcast_dims` work with `DimArray`s and `Dimension`s HOT 3
- `mapslices` on `DimStack` HOT 3
- add `name` etc keywords to `DimArray` `similar` HOT 1
- Support `replace!` for `DimStack`s HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dimensionaldata.jl.