rainforestapp / circlemator Goto Github PK

Immediate use case: we want to post a "code review checklist" when a migration is added/changed. This could be expanded for more code review based on the file, for instance "ping X for review when a model changes".

Thought for implementation:

Create a basic runner for https://github.com/mmozuras/pronto. Runner would be pretty basic:

• Repo would have a yml config file matching file name regexes to messages.
• The runner would just look through changed files and add comments to the PR as necessary.

@rainforestapp/devs sound sane?

Hi,
I came across this repo. ITs pretty cool, and literally replaces some bots that we have to do these tasks. That said, we are using CircleCI 2.0. Which of the current features can be used with circle2.0 config file format (workflows, jobs, etc).

Secondly, (naive question), is this codebase targeted only at Ruby apps? Will it work on a Go code base?

The style checker rather annoyingly will post the same comments over and over again when you keep pushing to the branch. I think a --clean option, which cleans out all comments by the bot, might be useful for that...

It looks like ESLint support would be fairly easy to add through https://github.com/mmozuras/pronto-eslint/blob/master/lib/pronto/eslint.rb . @rainforestapp/customer-product think it would be useful?

How about tagging a new release? master and 0.3.1 has 22 commits diff //cc @shosti