Giter VIP home page Giter VIP logo

penguinplayer's People

Contributors

dependabot[bot] avatar leostudiooo avatar yucling avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

penguinplayer's Issues

Lyric settings menu

Add a UI that can view full lyric of the current song and can modify some lyric settings

Scollbar problem

The scrollbar plugin that the player is using now has some disadvantages, in order to provide a better scrolling experience, a new scrollbar plugin is required. Or we can fall back to the native scrollbar.

Split different builds

Some users might need Internet Explorer support and some not, so it's necessary to split them out in order to make the player load faster and smaller.

Embed version

An embed version allows the player to be inserted directly into somewhere in the webpage. This will allow it to be created multiple times.

Improve code quality

Refactor player.ts to improve code quality, this will be very helpful when updating the player later.

handleNext error in random mode

Describe the bug
When play next, error appears by chance.

To Reproduce
Use random playmode, keep play next.

Expected behavior
No error

Desktop:

  • OS: Windows 10
  • Browser: Microsoft Edge
  • Version 100.0.1185.50

Additional context
Stacktrace:

Uncaught TypeError: Cannot read properties of undefined (reading 'index')
    at Object.handleNext (player.mjs:formatted:986:157)
    at ye.next (player.mjs:formatted:735:35)
    at MediaSession.<anonymous> (player.mjs:formatted:1059:99)
handleNext @ player.mjs:formatted:986
next @ player.mjs:formatted:735
(Anonymous) @ player.mjs:formatted:1059

Code clip

handleNext() {
    var e = this.findRandId(this.player.currentSongIndex);
    e < 0 || e >= this.randomizedList.length ? this.player.play(this.randomizedList[0].index) : this.player.play(this.randomizedList[e + 1].index)
}

Progress bar drag range issue

The progress bar won't be able to drag to the real position of the song's begin and end position when listening to VIP songs.

Support mobile and portable devices

Slider will cause errors when handling TouchEvent, as a result, most touch devices will not working properly if using this player.

Also, there is some style incompatible situation need to be fixed

Refactor code

Code must be refactored. It's now a mess, tidy it up might be helpful for later development.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.