rajinders / nlog-targets-azureeventhub Goto Github PK

AzureEventHubTarget implements IDisposable, but does not do anything when the object is disposed. It should be freeing up the resources related to the event hub client.

If a communication error occurs when a message is submit to Azure Event Hub the error is ignored and the log message lost.

The issue is that Write() starts a new task, but does not wait for it to complete.

What format is this serializing the events with? It looks like it's not JSON? Trying to apply stream analytics and as best I can tell the code is just taking the raw rendered layout string and not parsing it.

According to this comment for the PartitionKey property the key should be distributed evenly using round robin if no partition key is set.

        /// <summary>
        /// PartitionKey is optional. If no partition key is supplied the log messages are sent to eventhub
        /// and distributed to various partitions in a round robin manner.
        /// </summary>
        public string PartitionKey { get; set; }

From what I can see there is, no code doing anything with the key if it is not set?

using (var eventHubData = new EventData(Encoding.UTF8.GetBytes(logMessage)) { PartitionKey = partitionKey })
 {
                foreach (var key in logEvent.Properties.Keys)
                {
                    eventHubData.Properties.Add(key.ToString(), logEvent.Properties[key]);
                }

                await _eventHubClient.SendAsync(eventHubData);
                return true;
} 

As such the behaviour defaults back to whatever the SendAsync method does with a blank partition key.

According to the MSDN documentation it must have the partitionkey set.

Remarks
Any EventData instance send operation using this method must have the PartitionKey set.

In our case this leads to that we are only writing to one of the partitions all the time since the partitionkey is not changing and thus all scale advantages with the eventhub is gone.