ralfonso-directnic / cpanel_exporter Goto Github PK

This project looks useful, but please add a license so people can fork, modify it, and fix it.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository

However, without a license, the default copyright laws apply, meaning that you retain all rights to your source code and no one may reproduce, distribute, or create derivative works from your work.

Hi;

Thank you so much for the awesome cPanel exporter. I have found an issue where the values for cpanel_quota_used and cpanel_quota_percent are always zero. I have tested on 3 different servers and those values are never larger than zero.

The following error is also observed in logs

fetch.go:123: error: json: cannot unmarshal number into Go struct field .result.data.megabytes_used of type string
fetch.go:123: error: json: cannot unmarshal number into Go struct field .result.data.megabyte_limit of type string

I'm not familiar with Go and cannot help with fixing the issue, but I think the issue is caused by how cPanel UAPI returns data. I have noticed that the JSON response for the call /usr/bin/uapi --user=username --output=json Quota get_quota_info sometimes includes floats and sometimes string for the values of megabyte_limit and megabytes_remain depending on whether the package is configured with Unlimited quota or not.

Here are some sample relevant values from real accounts

"megabyte_limit":"0.00", "megabytes_remain":"0.00",  "megabytes_used":53.92
"megabyte_limit":"0.00", "megabytes_remain":"0.00",  "megabytes_used":3.05,
"megabyte_limit":"0.00", "megabytes_remain":"0.00",  "megabytes_used":18.57
"megabyte_limit":2000,   "megabytes_remain":1996.43, "megabytes_used":3.57
"megabyte_limit":4000,   "megabytes_remain":3975.55, "megabytes_used":24.45

I hope you find this helpful.

Started seeing that cpanel exporter keeps crashing with segmentation fault. This is happening on random servers.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x7f2fab]