Giter VIP home page Giter VIP logo

Comments (3)

Harris-Miller avatar Harris-Miller commented on July 18, 2024 1

@adispring I read through that PR along with the links to the other discussions from there.

I don't have a particularly strong opinion on the keep/no-keep argument. However, the fact of the matter is that placeholders are supported, and therefore need to be typed out

The argument I made above was specifically for the use cases that don't really make sense to keep

R.divide === R.divide() === R.divide(R.__);

But I'm willing to bet that somewhere someone has implemented

const toPercent = R.divide(R.__, 100);

So removing Placeholder support would break their code. Need to keep

from types.

Harris-Miller avatar Harris-Miller commented on July 18, 2024

It is also worth noting that there are many places in @types/ramda where there are typing for R.fn(__) that is incorrect. See lt for example

They have there

export function lt(__: Placeholder): (b: number, a: number) => boolean;

This implies that lt(__) is the same as flip(lt), which is incorrect. Therefore, those type definitions will be removes as part of types-ramda overall typing improvements

from types.

adispring avatar adispring commented on July 18, 2024

Or should we forbid using placeholder when use ramda with ts?

DefinitelyTyped/DefinitelyTyped#59579

from types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.