ramsey / devtools-lib Goto Github PK

Hi,

There is problem with the Windows environments. The phpunit command is not triggered because the binary is not correctly called.

./bin/devtools test:unit should be remplaced with php bin/devtools test:unit so this will work with both unix & windows systems.

But you will have some errors in the tests because the DIRECTORY_SEPARATOR constante is used so some tests will fails (ex : with windows the constructed path will be "/path/to/bin\foo" and it will compare in the phpunit a value of "/path/to/bin/foo").

I could try to do a PR if you wish.

Hi,

Interesting package. I have found that the latest composer version broke the devtools binary (https://github.com/ramsey/devtools-lib/blob/main/bin/devtools#L62).
You can see in your latest githubaction result the error :

Run ./bin/devtools test:unit
composer/package-versions-deprecated contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
PHP Fatal error:  Uncaught Symfony\Component\Console\Exception\InvalidArgumentException: The helper "question" is not defined. in /home/runner/work/devtools-lib/devtools-lib/vendor/symfony/console/Helper/HelperSet.php:70 php

Composer try to ask a question to update the "allow-plugin" section in the composer.json file (@see https://getcomposer.org/allow-plugins).
If you add a new QuestionHelper() in the new HelperSet() parameters it will result in a infinite loop with the question [I don't know why]. There is 3 possibilities to sole this :

1 - add a non interactive flag on the input object ($input->setInteractive(false);) i think it's the best solution.
2 - or when you create the composer instance you use the 3rd parameter to disable the plugins. (Factory::create($io, null, true);).
3 - Find why the question is asked in a infinite loop and avoid this problem :-) (but i didn"t find the "why" !!!)
[4 - Add the allow-plugin tag in the composer.json file to be ready for the futur composer version].

Hope this help.

The error is as follows:

Fatal error: Uncaught Error: Call to undefined method Symfony\Component\Process\Process::isTtySupported() in /Users/danpock/GitProjects/kickflip-src/vendor/ramsey/devtools-lib/src/Composer/Command/ProcessCommand.php:68

Seems to be from:

When running composer dev:lint:fix on very large files I have been experiencing a timeout at 60 seconds. It appears that in the Process and ProcessFactory classes the $timeout variable for the Symfony process is getting reset to 60 from whatever composer has set in the config since it is not getting passed along. I did some testing and by placing the variable in the process::_construct and ProcessFactory::factory functions they override to what is in those files. Although a cannot see where to make sure these are in place to make the composer config value move through the command properly.

Thoughts?

This workflow job showing tests running on PHP 8.1 results in a number of fatal errors in PHP:

ParseError: syntax error, unexpected token "static", expecting identifier

This appears to be the result of mockery/mockery#1155. I'm creating this issue to keep track of it here.