raysternwong / calculator Goto Github PK

Your code for evaluatePostfixesAndInfix() is unnecessarily lengthy and not driven by tests. That is the reason you have problem with removing the CLOSING_BRACKET or the precedence 10.

Please redo it from scratch. Make sure it is driven by tests! I know if it is driven by tests or written in advance before tests.

@wong: Please redo evaluatePostfixesAndInfix() as it is unnecessarily complex. It seems that you have been practicing your old habits again after your last pair-programming stint with me.

@mygamelife: I identified several tests in test_StringObject.c that cause the problem. Please see the following link:

chaosAD@0a776cc

I discovered that you didn't practice safe releasing of dynamic allocated memory. Please fix that.

This issue was first raised in: #29

@vuite: My machine fails to run "test_StringObject" using the latest codebase (#25). It ends with bad memory access. Please check your code.

There is some problems that I face for the last two test that is inside test_OperatorToken.c

@yanyin: Please pull the latest code from Wong's repo. The problem is it cannot
display the recalled history line.